Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 68933002: Added SchemaMap::GetChanges(). (Closed)

Created:
7 years, 1 month ago by Joao da Silva
Modified:
7 years, 1 month ago
Reviewers:
bartfab (slow)
CC:
chromium-reviews
Visibility:
Public.

Description

Added SchemaMap::GetChanges(). This method allows comparing an older and a newer instance of SchemaMap and get a list of components added and another of components removed. BUG=108992 R=bartfab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234516

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -0 lines) Patch
M chrome/browser/policy/schema_map.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/policy/schema_map.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/policy/schema_map_unittest.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M components/policy/core/common/policy_namespace.h View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Joao da Silva
Here's a small one for a change :-) This is a utility method to the ...
7 years, 1 month ago (2013-11-11 15:19:00 UTC) #1
bartfab (slow)
lgtm
7 years, 1 month ago (2013-11-11 15:40:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/68933002/1
7 years, 1 month ago (2013-11-11 18:09:20 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-11 19:50:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/68933002/210001
7 years, 1 month ago (2013-11-11 22:49:06 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=100439
7 years, 1 month ago (2013-11-12 03:05:28 UTC) #6
Joao da Silva
7 years, 1 month ago (2013-11-12 14:54:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r234516 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698