Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 689323002: Remove tests which are only testing getPropertyCSSValue, etc. (Closed)

Created:
6 years, 1 month ago by Timothy Loh
Modified:
6 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove tests which are only testing getPropertyCSSValue, etc. getPropertyCSSValue, CSSValue, etc. are no longer exposed to the web. This patch removes the tests which exist only to test this functionality. BUG=428595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -581 lines) Patch
D LayoutTests/fast/css/CSSPrimitiveValue-exceptions.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/css/CSSPrimitiveValue-exceptions-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/fast/css/counters/getCounterValue.html View 1 chunk +0 lines, -62 lines 0 comments Download
D LayoutTests/fast/css/counters/getCounterValue-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/css/getFloatValueForUnit.html View 1 chunk +0 lines, -55 lines 0 comments Download
D LayoutTests/fast/css/getFloatValueForUnit-expected.txt View 1 chunk +0 lines, -38 lines 0 comments Download
D LayoutTests/fast/css/image-value-type.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/css/image-value-type-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/css/resources/CSSPrimitiveValue-exceptions.js View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/fast/css/value-list-out-of-bounds-crash.html View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/fast/dom/StyleSheet/gc-inline-style-cssvalues.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/dom/StyleSheet/gc-inline-style-cssvalues-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/dom/css-RGBValue.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/dom/css-RGBValue-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/dom/script-tests/css-RGBValue.js View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/dom/script-tests/setPrimitiveValue-exceptions.js View 1 chunk +0 lines, -57 lines 0 comments Download
D LayoutTests/fast/dom/setPrimitiveValue.html View 1 chunk +0 lines, -46 lines 0 comments Download
D LayoutTests/fast/dom/setPrimitiveValue-exceptions.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/dom/setPrimitiveValue-exceptions-expected.txt View 1 chunk +0 lines, -65 lines 0 comments Download
D LayoutTests/fast/dom/setPrimitiveValue-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/platform/linux/fast/css/value-list-out-of-bounds-crash-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/css/value-list-out-of-bounds-crash-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/platform/mac/fast/css/value-list-out-of-bounds-crash-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/css/value-list-out-of-bounds-crash-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/css/value-list-out-of-bounds-crash-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/css/value-list-out-of-bounds-crash-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/platform/win/fast/css/value-list-out-of-bounds-crash-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/css/value-list-out-of-bounds-crash-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Timothy Loh
..the first of many patches to get rid of getPropertyCSSValue in layout tests...
6 years, 1 month ago (2014-11-03 23:38:20 UTC) #2
alancutter (OOO until 2018)
lgtm
6 years, 1 month ago (2014-11-03 23:45:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689323002/1
6 years, 1 month ago (2014-11-03 23:45:53 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 23:48:31 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 184808

Powered by Google App Engine
This is Rietveld 408576698