Merge 84909 - 2011-04-26 Pavel Feldman <pfeldman@google.com> Web Inspector: New Style is...

Source/WebCore/inspector/front-end/AuditRules.js

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 745 matching lines @@
                 for (var i = 0; i < urlViolations[1].length; ++i)
                     result.addChild(String.sprintf("Link node %s should be moved to the document head in %s", WebInspector.AuditRuleResult.linkifyDisplayName(urlViolations[1][i]), WebInspector.AuditRuleResult.linkifyDisplayName(url)));
                 result.violationCount += urlViolations[1].length;
             }
             summary.value = String.sprintf("CSS in the document body adversely impacts rendering performance.");
             callback(result);
         }
 
         function externalStylesheetsReceived(root, inlineStyleNodeIds, nodeIds)
         {
+            if (!nodeIds) {
+                callback(null);
+                return;
+            }
+
             var externalStylesheetNodeIds = nodeIds;
             var result = null;
             if (inlineStyleNodeIds.length || externalStylesheetNodeIds.length) {
                 var urlToViolationsArray = {};
                 var externalStylesheetHrefs = [];
                 for (var j = 0; j < externalStylesheetNodeIds.length; ++j) {
                     var linkNode = WebInspector.domAgent.nodeForId(externalStylesheetNodeIds[j]);
                     var completeHref = WebInspector.completeURL(linkNode.ownerDocument.documentURL, linkNode.getAttribute("href"));
                     externalStylesheetHrefs.push(completeHref || "<empty>");
                 }
                 urlToViolationsArray[root.documentURL] = [inlineStyleNodeIds.length, externalStylesheetHrefs];
                 result = urlToViolationsArray;
             }
             evalCallback(result);
         }
 
         function inlineStylesReceived(root, nodeIds)
         {
+            if (!nodeIds) {
+                callback(null);
+                return;
+            }
+
             WebInspector.domAgent.querySelectorAll(root.id, "body link[rel~='stylesheet'][href]", externalStylesheetsReceived.bind(null, root, nodeIds));
         }
 
         function onDocumentAvailable(root)
         {
             WebInspector.domAgent.querySelectorAll(root.id, "body style", inlineStylesReceived.bind(null, root));
         }
 
         WebInspector.domAgent.requestDocument(onDocumentAvailable);
     }
@@ skipping 24 matching lines @@
 
             if (cssBeforeInlineCount) {
                 result.addChild(String.sprintf(" %d inline script block%s found in the head between an external CSS file and another resource. To allow parallel downloading, move the inline script before the external CSS file, or after the next resource.", cssBeforeInlineCount, cssBeforeInlineCount > 1 ? "s were" : " was"));
                 result.violationCount += cssBeforeInlineCount;
             }
             callback(result);
         }
 
         function cssBeforeInlineReceived(lateStyleIds, nodeIds)
         {
+            if (!nodeIds) {
+                callback(null);
+                return;
+            }
+
             var cssBeforeInlineCount = nodeIds.length;
             var result = null;
             if (lateStyleIds.length || cssBeforeInlineCount) {
                 var lateStyleUrls = [];
                 for (var i = 0; i < lateStyleIds.length; ++i) {
                     var lateStyleNode = WebInspector.domAgent.nodeForId(lateStyleIds[i]);
                     var completeHref = WebInspector.completeURL(lateStyleNode.ownerDocument.documentURL, lateStyleNode.getAttribute("href"));
                     lateStyleUrls.push(completeHref || "<empty>");
                 }
                 result = [ lateStyleUrls, cssBeforeInlineCount ];
             }
 
             evalCallback(result);
         }
 
         function lateStylesReceived(root, nodeIds)
         {
+            if (!nodeIds) {
+                callback(null);
+                return;
+            }
+
             WebInspector.domAgent.querySelectorAll(root.id, "head link[rel~='stylesheet'][href] ~ script:not([src])", cssBeforeInlineReceived.bind(null, nodeIds));
         }
 
         function onDocumentAvailable(root)
         {
             WebInspector.domAgent.querySelectorAll(root.id, "head script[src] ~ link[rel~='stylesheet'][href]", lateStylesReceived.bind(null, root));
         }
 
         WebInspector.domAgent.requestDocument(onDocumentAvailable);
     }
@@ skipping 183 matching lines @@
         result.violationCount = badUrls.length;
     },
 
     _collectorCallback: function(matchingResourceData, resource, cookie)
     {
         matchingResourceData[resource.url] = (matchingResourceData[resource.url] || 0) + cookie.size;
     }
 }
 
 WebInspector.AuditRules.StaticCookielessRule.prototype.__proto__ = WebInspector.AuditRules.CookieRuleBase.prototype;