Issue 689293003: Notify client when AssociatedURLLoader fail because of unallowed redirect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 689293003: Notify client when AssociatedURLLoader fail because of unallowed redirect. (Closed)

Created:
6 years, 1 month ago by mlamouri (slow - plz ping)

Modified:
6 years, 1 month ago

Reviewers:
Mike West

CC:
blink-reviews, benwells

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Notify client when AssociatedURLLoader fail because of unallowed redirect. ::didFail() is used instead of ::cancel() when a redirect failure happen. The same way ::didFail() is used when an access control failure happens. This is testing the change but also re-enables a test related to redirection. BUG=240912, 429458 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184778

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -7 lines)			Patch
	M	Source/web/AssociatedURLLoader.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/web/tests/AssociatedURLLoaderTest.cpp	View		3 chunks	+54 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689293003/1

6 years, 1 month ago (2014-11-02 18:22:56 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-02 18:56:56 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 184778

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages