Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Issue 689253002: gpu: Remove flush of command buffer before creating a new image. (Closed)

Created:
6 years, 1 month ago by reveman
Modified:
6 years, 1 month ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gpu: Remove flush of command buffer before creating a new image. This is unnecessary as image ids are not reused. CreateImage will fail if generation of image ids wraparound as negative ids are considered an error. R=piman@chromium.org BUG= Committed: https://crrev.com/93b8beea2b4716d2484f3499a6370c92d3e39b30 Cr-Commit-Position: refs/heads/master@{#302385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
reveman
6 years, 1 month ago (2014-10-31 23:37:08 UTC) #1
piman
lgtm
6 years, 1 month ago (2014-11-01 00:00:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689253002/1
6 years, 1 month ago (2014-11-01 12:28:40 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-01 13:09:39 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-01 13:10:18 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93b8beea2b4716d2484f3499a6370c92d3e39b30
Cr-Commit-Position: refs/heads/master@{#302385}

Powered by Google App Engine
This is Rietveld 408576698