Issue 689243003: fix sky element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 689243003: fix sky element (Closed)

Created:
6 years, 1 month ago by rafaelw

Modified:
6 years, 1 month ago

Reviewers:
abarth-chromium

CC:
esprehn, mojo-reviews_chromium.org, ojan

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Fix SkyElement Adam broke this when trying to refactor it. This CL is just a partial revert of his CL. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3b50fa51a3dca34fcdc2ba7d1e341b44fa1a9ce2

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	sky/framework/sky-element/sky-element.sky	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

abarth-chromium

If you don't mind, I'd like to land this CL. I'm working on some examples ...

6 years, 1 month ago (2014-11-03 18:14:43 UTC) #3

abarth-chromium

6 years, 1 month ago (2014-11-03 18:15:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
3b50fa51a3dca34fcdc2ba7d1e341b44fa1a9ce2 (presubmit successful).