Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 689243002: Fix the port of remote HostPortPair in P2PSocketHostTcpBase::Init. (Closed)

Created:
6 years, 1 month ago by jiayl
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix the port of remote HostPortPair in P2PSocketHostTcpBase::Init. BUG=webrtc:3868 Committed: https://crrev.com/0a6de71f7e505780e518a64b0faa5b7e3bc3a0de Cr-Commit-Position: refs/heads/master@{#302359}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/renderer_host/p2p/socket_host_tcp.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jiayl
PTAL
6 years, 1 month ago (2014-10-31 22:39:41 UTC) #2
Mallinath (Gone from Chromium)
lgtm
6 years, 1 month ago (2014-10-31 22:45:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689243002/1
6 years, 1 month ago (2014-10-31 22:50:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-01 00:02:57 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-01 00:03:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a6de71f7e505780e518a64b0faa5b7e3bc3a0de
Cr-Commit-Position: refs/heads/master@{#302359}

Powered by Google App Engine
This is Rietveld 408576698