Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 689223002: Don't assume gfx::Screen::GetNumDisplays() == GetAllDisplays().size(). (Closed)

Created:
6 years, 1 month ago by Reilly Grant (use Gerrit)
Modified:
6 years, 1 month ago
Reviewers:
Hongbo Min
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't assume gfx::Screen::GetNumDisplays() == GetAllDisplays().size(). It is safer to use the C++11 foreach operator to iterate over this vector. On Windows gfx::ScreenWin gets the the display count from a different place from the display list. BUG=427931 Committed: https://crrev.com/dbd94f7916ed11a14deddaa53db6f84ce5fd1b57 Cr-Commit-Position: refs/heads/master@{#302416}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M extensions/browser/api/system_display/display_info_provider.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Reilly Grant (use Gerrit)
hongbo.min@intel.com, please take a look.
6 years, 1 month ago (2014-10-31 21:49:21 UTC) #2
Hongbo Min
lgtm. thanks.
6 years, 1 month ago (2014-11-03 01:00:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689223002/1
6 years, 1 month ago (2014-11-03 06:00:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-03 06:40:34 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 06:41:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dbd94f7916ed11a14deddaa53db6f84ce5fd1b57
Cr-Commit-Position: refs/heads/master@{#302416}

Powered by Google App Engine
This is Rietveld 408576698