Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 689213002: Fix calling of device.PushChangedFiles in android platform telemetry (Closed)

Created:
6 years, 1 month ago by sclittle
Modified:
6 years, 1 month ago
Reviewers:
wuhu, marja
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix calling of device.PushChangedFiles in android platform telemetry. This fixes the call of device.PushChangedFiles; see example of correct usage here: https://code.google.com/p/chromium/codesearch#chromium/src/build/android/provision_devices.py&q=PushChangedFiles This change should fix the breakage of the chrome-proxy tests that was introduced in https://codereview.chromium.org/656383002/. BUG=429313 Committed: https://crrev.com/4db20127805bede08bc35f3dcb784f60a51538bc Cr-Commit-Position: refs/heads/master@{#302556}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
sclittle
wuhu: all Thanks in advance
6 years, 1 month ago (2014-10-31 20:42:54 UTC) #2
sclittle
Added marja as reviewer for OWNERS
6 years, 1 month ago (2014-10-31 20:46:34 UTC) #4
wuhu
On 2014/10/31 20:46:34, sclittle wrote: > Added marja as reviewer for OWNERS LGTM
6 years, 1 month ago (2014-10-31 21:10:54 UTC) #5
marja
lgtm
6 years, 1 month ago (2014-11-03 08:37:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689213002/1
6 years, 1 month ago (2014-11-03 17:52:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 02:47:25 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 02:48:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4db20127805bede08bc35f3dcb784f60a51538bc
Cr-Commit-Position: refs/heads/master@{#302556}

Powered by Google App Engine
This is Rietveld 408576698