Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 689123003: Revert of Navigation transitions (web to native app): Pass data after starting provisional load ... (Closed)

Created:
6 years, 1 month ago by Hajime Morrita
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Navigation transitions (web to native app): Pass data after starting provisional load (Chrome side) (patchset #7 id:120001 of https://codereview.chromium.org/652953008/) Reason for revert: Crashing a LayoutTest http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=ChromiumWebkit&tests=fast/html/navigation-transition.html Hitting an assertion: 10:15:12.016 3607 [10283:10283:1031/101511:5678803780814:FATAL:transition_request_manager.cc(161)] Check failed: ::content::BrowserThread::CurrentlyOn(BrowserThread::IO). Must be called on Chrome_IOThread; actually called on CrBrowserMain. 10:15:12.016 3607 #0 0x7f66666664ce base::debug::StackTrace::StackTrace() 10:15:12.016 3607 #1 0x7f6666700bf5 logging::LogMessage::~LogMessage() 10:15:12.016 3607 #2 0x7f66612dcafa content::TransitionRequestManager::GetPendingTransitionRequest() 10:15:12.016 3607 #3 0x7f6660bccdb1 content::NavigatorImpl::DidStartProvisionalLoad() 10:15:12.016 3607 #4 0x7f6660bdb821 content::RenderFrameHostImpl::OnDidStartProvisionalLoadForFrame() 10:15:12.016 3607 #5 0x7f6660bf3554 DispatchToMethod<>() 10:15:12.016 3607 #6 0x7f6660be38b7 FrameHostMsg_DidStartProvisionalLoadForFrame::Dispatch<>() 10:15:12.016 3607 #7 0x7f6660bda57e content::RenderFrameHostImpl::OnMessageReceived() 10:15:12.016 3607 #8 0x7f666103ad0e content::RenderProcessHostImpl::OnMessageReceived() 10:15:12.016 3607 #9 0x7f666103b11f content::RenderProcessHostImpl::OnMessageReceived() 10:15:12.016 3607 #10 0x7f6664fe5e9d IPC::ChannelProxy::Context::OnDispatchMessage() 10:15:12.016 3607 #11 0x7f6664feea5a base::internal::RunnableAdapter<>::Run() 10:15:12.016 3607 #12 0x7f6664fee9b1 base::internal::InvokeHelper<>::MakeItSo() 10:15:12.016 3607 #13 0x7f6664fee94c base::internal::Invoker<>::Run() 10:15:12.016 3607 #14 0x7f666664eb3e base::Callback<>::Run() 10:15:12.016 3607 #15 0x7f666666cb89 base::debug::TaskAnnotator::RunTask() 10:15:12.016 3607 #16 0x7f6666729968 base::MessageLoop::RunTask() 10:15:12.016 3607 #17 0x7f6666729acb base::MessageLoop::DeferOrRunPendingTask() 10:15:12.016 3607 #18 0x7f6666729d05 base::MessageLoop::DoWork() 10:15:12.016 3607 #19 0x7f66666227bc base::MessagePumpGlib::HandleDispatch() 10:15:12.016 3607 #20 0x7f6666622fd1 base::(anonymous namespace)::WorkSourceDispatch() 10:15:12.016 3607 #21 0x7f6658588d13 g_main_context_dispatch 10:15:12.016 3607 #22 0x7f6658589060 <unknown> 10:15:12.016 3607 #23 0x7f6658589124 g_main_context_iteration 10:15:12.016 3607 #24 0x7f66666228c5 base::MessagePumpGlib::Run() 10:15:12.016 3607 #25 0x7f6666729432 base::MessageLoop::RunHandler() 10:15:12.016 3607 #26 0x7f66667920d4 base::RunLoop::Run() 10:15:12.016 3607 #27 0x7f66609ca164 content::BrowserMainLoop::MainMessageLoopRun() 10:15:12.016 3607 #28 0x7f66609c9fc1 content::BrowserMainLoop::RunMainMessageLoopParts() 10:15:12.016 3607 #29 0x7f66609d3075 content::BrowserMainRunnerImpl::Run() 10:15:12.016 3607 #30 0x000000452ef4 (anonymous namespace)::RunOneTest() 10:15:12.016 3607 #31 0x000000452b53 (anonymous namespace)::RunTests() 10:15:12.016 3607 #32 0x0000004529af LayoutTestBrowserMain() 10:15:12.016 3607 #33 0x00000044fcda content::ShellMainDelegate::RunProcess() 10:15:12.017 3607 #34 0x7f6660849f01 content::RunNamedProcessTypeMain() 10:15:12.017 3607 #35 0x7f666084e232 content::ContentMainRunnerImpl::Run() 10:15:12.017 3607 #36 0x7f66608493f5 content::ContentMain() 10:15:12.017 3607 #37 0x00000044ee5c main 10:15:12.017 3607 #38 0x7f665785676d __libc_start_main 10:15:12.017 3607 #39 0x00000044ed49 <unknown> Original issue's description: > Navigation transitions (web to native app): Pass data after starting provisional load (Chrome side) > > Pass transitional elements' CSS selector, names and rects to TransitionPageHelper after starting provisional load. Those data are needed when overriding the URL navigation to jump to a native Android app. > > The is the Chrome side of the CL. The Clank side is here: https://chrome-internal-review.googlesource.com/#/c/180668/ > > BUG=370696 > > Committed: https://crrev.com/5b846f579d3dd1a0f4d0b8c26ff274117bfba0bc > Cr-Commit-Position: refs/heads/master@{#302279} TBR=nasko@chromium.org,sievers@chromium.org,oysteine@chromium.org,zhenw@chromium.org NOTREECHECKS=true NOTRY=true BUG=370696 Committed: https://crrev.com/ffb8261db9491e5d1ce9b9eb76941f99f7df7011 Cr-Commit-Position: refs/heads/master@{#302284}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -139 lines) Patch
M content/browser/frame_host/navigator_delegate.h View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 chunk +2 lines, -10 lines 0 comments Download
M content/browser/loader/cross_site_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/transition_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/transition_request_manager.h View 6 chunks +14 lines, -15 lines 0 comments Download
M content/browser/transition_request_manager.cc View 5 chunks +16 lines, -9 lines 0 comments Download
M content/browser/web_contents/web_contents_android.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_android.cc View 1 chunk +2 lines, -18 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/common/frame_messages.h View 3 chunks +9 lines, -14 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java View 1 chunk +2 lines, -11 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/NavigationTransitionDelegate.java View 1 chunk +1 line, -13 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/TransitionTest.java View 1 chunk +1 line, -6 lines 0 comments Download
D content/public/common/transition_element.h View 1 chunk +0 lines, -23 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Hajime Morrita
Created Revert of Navigation transitions (web to native app): Pass data after starting provisional load ...
6 years, 1 month ago (2014-10-31 18:24:08 UTC) #1
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 19:46:59 UTC) #3
CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/689123003/1

Powered by Google App Engine
This is Rietveld 408576698