Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 689103003: Prevent leak on completion of drop operation. (Closed)

Created:
6 years, 1 month ago by sof
Modified:
6 years, 1 month ago
Reviewers:
dcheng
CC:
dcheng, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Prevent leak on completion of drop operation. If the 'drop' event handler signals that the event has been handled and no default handling is to be done, we clear the document and consider the operation complete. Also clear out the drag caret selection at that time, as it may hold onto an anchor node (and its document.) R=dcheng BUG=364417 TEST=fast/dom/shadow/drop-event-for-input-in-shadow.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184768

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/core/page/DragController.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
sof
Please take a look. I _believe_ it is acceptable to clear the caret controller at ...
6 years, 1 month ago (2014-10-31 16:22:56 UTC) #2
dcheng
Do you mind explaining why this leaks without the change?
6 years, 1 month ago (2014-10-31 17:53:22 UTC) #3
sof
On 2014/10/31 17:53:22, dcheng wrote: > Do you mind explaining why this leaks without the ...
6 years, 1 month ago (2014-10-31 19:14:49 UTC) #4
sof
Checking with Chromium bots; reporting green.
6 years, 1 month ago (2014-10-31 21:02:41 UTC) #5
dcheng
OK, makes sense. Is there any way we can reduce the amount of manual calls ...
6 years, 1 month ago (2014-10-31 22:26:54 UTC) #6
sof
On 2014/10/31 22:26:54, dcheng wrote: > OK, makes sense. > > Is there any way ...
6 years, 1 month ago (2014-11-01 05:43:00 UTC) #7
dcheng
lgtm
6 years, 1 month ago (2014-11-01 06:27:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689103003/1
6 years, 1 month ago (2014-11-01 06:36:44 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-01 07:10:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184768

Powered by Google App Engine
This is Rietveld 408576698