Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 689093004: Revert of Remote assistance on Chrome OS Part V - It2MeHost Continue Window (Closed)

Created:
6 years, 1 month ago by kelvinp
Modified:
6 years, 1 month ago
Reviewers:
Wez, dcaiafa
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Remote assistance on Chrome OS Part V - It2MeHost Continue Window (patchset #5 id:120001 of https://codereview.chromium.org/690183002/) Reason for revert: Build failure on http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Builder%20%28dbg%29&number=54095 Original issue's description: > Remote assistance on Chrome OS Part V - It2MeHost Continue Window > > This CL implements the ContinueWindow on ChromeOS, which will > be shown to the user for confirmation after 10 minutes into a Remote > Assistance session. > > To implement the ContinueWindow, this CL introduces a new class > MessageBox, which is a re-usable component built on top of the > widget framework. > > BUG=424908 > > Committed: https://crrev.com/6410d7ad4937a4a86e9ad28b9ecf99f961305b2d > Cr-Commit-Position: refs/heads/master@{#302657} TBR=wez@chromium.org,dcaiafa@chromium.org NOTREECHECKS=true NOTRY=true BUG=424908 Committed: https://crrev.com/71ffa2147e36e87212d2a1e0c56d47cdc77a8410 Cr-Commit-Position: refs/heads/master@{#302660}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -272 lines) Patch
D remoting/host/chromeos/message_box.h View 1 chunk +0 lines, -49 lines 0 comments Download
D remoting/host/chromeos/message_box.cc View 1 chunk +0 lines, -194 lines 0 comments Download
M remoting/host/continue_window_chromeos.cc View 2 chunks +7 lines, -25 lines 0 comments Download
M remoting/remoting_host.gypi View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kelvinp
Created Revert of Remote assistance on Chrome OS Part V - It2MeHost Continue Window
6 years, 1 month ago (2014-11-04 20:54:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689093004/1
6 years, 1 month ago (2014-11-04 20:55:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 20:57:23 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 20:58:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71ffa2147e36e87212d2a1e0c56d47cdc77a8410
Cr-Commit-Position: refs/heads/master@{#302660}

Powered by Google App Engine
This is Rietveld 408576698