Right clicking outside of a selected area should deselect text and bring up the correct context men…

pdf/pdfium/pdfium_engine.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PDF_PDFIUM_PDFIUM_ENGINE_H_
 #define PDF_PDFIUM_PDFIUM_ENGINE_H_
 
 #include <map>
 #include <string>
 #include <utility>
@@ skipping 228 matching lines @@
 
   // Checks if a page is now available, and if so marks it as such and returns
   // true.  Otherwise, it will return false and will add the index to the given
   // array if it's not already there.
   bool CheckPageAvailable(int index, std::vector<int>* pending);
 
   // Helper function to get a given page's size in pixels.  This is not part of
   // PDFiumPage because we might not have that structure when we need this.
   pp::Size GetPageSize(int index);
 
+  void GetAllScreenRectsUnion(std::vector<PDFiumRange> rectRange,

[gene, 2015/01/06 18:40:04]

nit: variable names are not camel case (like offset_point below)
nit2: please use const reference here instead of pass by value

[Deepak, 2015/01/07 04:59:01]

changed to reference, but can not use const as GetScreenRect() is not marked as
const.

+                              const pp::Point offset_point,

[gene, 2015/01/06 18:40:04]

nit: const reference?

[Deepak, 2015/01/07 04:59:01]

Done.

+                              std::vector<pp::Rect>& rectVector);

[gene, 2015/01/06 18:40:04]

nit: variable names are not camel case (like offset_point above)
nit2: if you need to return vector, please use pointer instead of reference (see
CheckPageAvailable above)

[Deepak, 2015/01/07 04:59:01]

Done.

+
   void UpdateTickMarks();
 
   // Called to continue searching so we don't block the main thread.
   void ContinueFind(int32_t result);
 
   // Inserts a find result into find_results_, which is sorted.
   void AddFindResult(const PDFiumRange& result);
 
   // Search a page using PDFium's methods.  Doesn't work with unicode.  This
   // function is just kept arount in case PDFium code is fixed.
@@ skipping 478 matching lines @@
 
   // See the definition of GetPDFPageSizeByIndex in pdf.cc for details.
   virtual bool GetPDFPageSizeByIndex(const void* pdf_buffer,
                                      int pdf_buffer_size, int page_number,
                                      double* width, double* height);
 };
 
 }  // namespace chrome_pdf
 
 #endif  // PDF_PDFIUM_PDFIUM_ENGINE_H_