Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 689003002: Fix auto opening FSP volumes on mount. (Closed)

Created:
6 years, 1 month ago by mtomasz
Modified:
6 years, 1 month ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix auto opening FSP volumes on mount. Previously, I didn't test it carefully... TEST=Tested manually. BUG=427776 Committed: https://crrev.com/f60b0206d617cabb0381a58af3dfdb18bc1b448a Cr-Commit-Position: refs/heads/master@{#302240}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M ui/file_manager/file_manager/foreground/js/directory_model.js View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mtomasz
@hirono: PTAL one more time. The previous fix was buggy. Thanks.
6 years, 1 month ago (2014-10-31 06:47:17 UTC) #2
hirono
lgtm, sorry I noticed the displayRoot can be null, but I misunderstood as it is ...
6 years, 1 month ago (2014-10-31 06:51:48 UTC) #3
mtomasz
On 2014/10/31 06:51:48, hirono wrote: > lgtm, sorry I noticed the displayRoot can be null, ...
6 years, 1 month ago (2014-10-31 06:57:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689003002/1
6 years, 1 month ago (2014-10-31 06:58:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 07:41:47 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 07:42:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f60b0206d617cabb0381a58af3dfdb18bc1b448a
Cr-Commit-Position: refs/heads/master@{#302240}

Powered by Google App Engine
This is Rietveld 408576698