Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1486)

Issue 688993004: [chrome/browser/s*] Convert VLOGs to DVLOGs (Closed)

Created:
6 years, 1 month ago by anujsharma
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[chrome/browser/s*] Convert VLOGs to DVLOGs Note: s* includes -->(safe_browsing, service_process, sessions, signin, ssl, supervised_user, sync modules) BUG=101424 Committed: https://crrev.com/14caff1993c280bd5979706f50d0e454ba3b9772 Cr-Commit-Position: refs/heads/master@{#302962}

Patch Set 1 #

Patch Set 2 : Fixed Indentations #

Patch Set 3 : Rebasing the patch and removing supervised_users related change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -116 lines) Patch
M chrome/browser/safe_browsing/binary_feature_extractor_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.cc View 1 6 chunks +21 lines, -21 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/database_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_protection_service.cc View 1 2 8 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager.cc View 1 2 3 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/sandboxed_zip_analyzer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/service_process/service_process_control.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_restore.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_service_commands.cc View 1 2 17 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/signin/android_profile_oauth2_token_service.cc View 12 chunks +24 lines, -24 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_signin_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ssl/ssl_client_auth_observer.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (5 generated)
anujsharma
PTAL
6 years, 1 month ago (2014-11-03 12:59:18 UTC) #2
anujsharma
On 2014/11/03 12:59:18, anujsharma wrote: > PTAL @blundell- PTAL in signin module @sky- PTAL in ...
6 years, 1 month ago (2014-11-04 10:32:11 UTC) #4
Bernhard Bauer
+antrim for Chrome OS supervised users. I was under the impression that Chrome OS generally ...
6 years, 1 month ago (2014-11-04 12:02:57 UTC) #6
blundell
blundell -> rogerta
6 years, 1 month ago (2014-11-04 15:06:01 UTC) #8
Roger Tawa OOO till Jul 10th
lgtm chrome/browser/signin
6 years, 1 month ago (2014-11-04 16:10:05 UTC) #9
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 1 month ago (2014-11-04 16:46:25 UTC) #10
palmer
Rubberstamp LGTM
6 years, 1 month ago (2014-11-04 19:44:23 UTC) #11
mattm
lgtm
6 years, 1 month ago (2014-11-04 22:59:31 UTC) #12
anujsharma
On 2014/11/04 10:32:11, anujsharma wrote: > On 2014/11/03 12:59:18, anujsharma wrote: > > PTAL > ...
6 years, 1 month ago (2014-11-05 14:37:46 UTC) #13
sky
What specific files do you need me to look at? In general prefer local owners. ...
6 years, 1 month ago (2014-11-05 15:42:27 UTC) #14
anujsharma
On 2014/11/05 15:42:27, sky wrote: > What specific files do you need me to look ...
6 years, 1 month ago (2014-11-05 17:39:42 UTC) #15
sky
sessions LGTM
6 years, 1 month ago (2014-11-05 20:03:41 UTC) #16
anujsharma
On 2014/11/05 20:03:41, sky wrote: > sessions LGTM Thanks sky for lgtm.
6 years, 1 month ago (2014-11-06 02:53:18 UTC) #17
anujsharma
On 2014/11/04 12:02:57, Bernhard Bauer wrote: > +antrim for Chrome OS supervised users. > > ...
6 years, 1 month ago (2014-11-06 02:54:59 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688993004/40001
6 years, 1 month ago (2014-11-06 02:56:09 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-06 04:28:45 UTC) #21
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 04:29:21 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/14caff1993c280bd5979706f50d0e454ba3b9772
Cr-Commit-Position: refs/heads/master@{#302962}

Powered by Google App Engine
This is Rietveld 408576698