On 2014/11/03 12:59:18, anujsharma wrote:
> PTAL
@blundell- PTAL in signin module
@sky- PTAL in sessions module
@maniscalco- PTAL in test module
@vitalybuka- PTAL in service_process module
@palmer- PTAL in ssl module
@mattm -PTAL in safe-browsing module
@bauerb- PTAL in supervised_user module
+antrim for Chrome OS supervised users.
I was under the impression that Chrome OS generally only builds in Release mode,
so DVLOGs wouldn't get logged.
6 years, 1 month ago
(2014-11-04 16:46:25 UTC)
#10
lgtm
palmer
Rubberstamp LGTM
6 years, 1 month ago
(2014-11-04 19:44:23 UTC)
#11
Rubberstamp LGTM
mattm
lgtm
6 years, 1 month ago
(2014-11-04 22:59:31 UTC)
#12
lgtm
anujsharma
On 2014/11/04 10:32:11, anujsharma wrote: > On 2014/11/03 12:59:18, anujsharma wrote: > > PTAL > ...
6 years, 1 month ago
(2014-11-05 14:37:46 UTC)
#13
On 2014/11/04 10:32:11, anujsharma wrote:
> On 2014/11/03 12:59:18, anujsharma wrote:
> > PTAL
>
> @blundell- PTAL in signin module
> @sky- PTAL in sessions module
> @maniscalco- PTAL in test module
> @vitalybuka- PTAL in service_process module
> @palmer- PTAL in ssl module
> @mattm -PTAL in safe-browsing module
> @bauerb- PTAL in supervised_user module
Thanks Roger, Vitaly, Chromium Palmer and matt for lgtm.
@sky,antrim,maniscalco - could you also give thumbs up for this CL.
Thanks!!
sky
What specific files do you need me to look at? In general prefer local owners. ...
6 years, 1 month ago
(2014-11-05 15:42:27 UTC)
#14
What specific files do you need me to look at? In general prefer local owners.
Is there not a more local owner for the files you're going to ask me to review?
anujsharma
On 2014/11/05 15:42:27, sky wrote: > What specific files do you need me to look ...
6 years, 1 month ago
(2014-11-05 17:39:42 UTC)
#15
On 2014/11/05 15:42:27, sky wrote:
> What specific files do you need me to look at? In general prefer local owners.
> Is there not a more local owner for the files you're going to ask me to
review?
Sorry sky for the inconvenience caused. I want to you
src/chrome/browser/sessions module. Actually for this module, only you and Marja
are the OWNERS, thats why i send review request to you. Sorry if i am wrong
somewhere.
Thanks!!
sky
sessions LGTM
6 years, 1 month ago
(2014-11-05 20:03:41 UTC)
#16
sessions LGTM
anujsharma
On 2014/11/05 20:03:41, sky wrote: > sessions LGTM Thanks sky for lgtm.
6 years, 1 month ago
(2014-11-06 02:53:18 UTC)
#17
On 2014/11/05 20:03:41, sky wrote:
> sessions LGTM
Thanks sky for lgtm.
anujsharma
On 2014/11/04 12:02:57, Bernhard Bauer wrote: > +antrim for Chrome OS supervised users. > > ...
6 years, 1 month ago
(2014-11-06 02:54:59 UTC)
#18
On 2014/11/04 12:02:57, Bernhard Bauer wrote:
> +antrim for Chrome OS supervised users.
>
> I was under the impression that Chrome OS generally only builds in Release
mode,
> so DVLOGs wouldn't get logged.
@Bauer, antrim,
I have removed Chrome OS supervised users from this CL.
Thanks for your time.
anujsharma
The CQ bit was checked by anujk.sharma@samsung.com
6 years, 1 month ago
(2014-11-06 02:55:10 UTC)
#19
Issue 688993004: [chrome/browser/s*] Convert VLOGs to DVLOGs
(Closed)
Created 6 years, 1 month ago by anujsharma
Modified 6 years, 1 month ago
Reviewers: sky, maniscalco, Vitaly Buka (NO REVIEWS), palmer, mattm, Bernhard Bauer, Denis Kuznetsov (DE-MUC), Roger Tawa OOO till Jul 10th, blundell
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 0