Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 688983004: WebCrypto: Don't check for negative values from EVP_DigestVerifyFinal. (Closed)

Created:
6 years, 1 month ago by eroman
Modified:
6 years, 1 month ago
Reviewers:
davidben
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

WebCrypto: Don't check for negative values from EVP_DigestVerifyFinal. BoringSSL can no longer return negative values for it. Committed: https://crrev.com/58fd4f4c6ec98f7cc04fbfe039ed8bf6ad36a05d Cr-Commit-Position: refs/heads/master@{#303574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M content/child/webcrypto/openssl/rsa_sign_openssl.cc View 1 chunk +3 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
eroman
6 years, 1 month ago (2014-11-08 02:20:27 UTC) #2
davidben
lgtm
6 years, 1 month ago (2014-11-10 20:26:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688983004/1
6 years, 1 month ago (2014-11-10 20:45:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/20767)
6 years, 1 month ago (2014-11-10 21:22:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688983004/1
6 years, 1 month ago (2014-11-11 02:21:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-11 02:37:56 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 02:38:20 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58fd4f4c6ec98f7cc04fbfe039ed8bf6ad36a05d
Cr-Commit-Position: refs/heads/master@{#303574}

Powered by Google App Engine
This is Rietveld 408576698