Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/core/html/HTMLTitleElement.cpp

Issue 688933002: Make textContent trigger single DOMSubtreeModified event (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add test Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/dom/ContainerNode.cpp ('K') | « Source/core/dom/Node.cpp ('k') | Source/core/svg/SVGUseElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLTitleElement.cpp
diff --git a/Source/core/html/HTMLTitleElement.cpp b/Source/core/html/HTMLTitleElement.cpp
index 659bdab424b9249983129e663bf485e088e67fc2..97f622f7dbd1494446a45b3d3d1a14019179fff7 100644
--- a/Source/core/html/HTMLTitleElement.cpp
+++ b/Source/core/html/HTMLTitleElement.cpp
@@ -85,7 +85,7 @@ void HTMLTitleElement::setText(const String &value)
// Avoid calling Document::setTitleElement() during intermediate steps.
m_ignoreTitleUpdatesWhenChildrenChange = !value.isEmpty();
- removeChildren();
+ removeChildren(false);
sof 2014/11/20 12:09:59 Would be good to have test coverage for this.
m_ignoreTitleUpdatesWhenChildrenChange = false;
if (!value.isEmpty())
« Source/core/dom/ContainerNode.cpp ('K') | « Source/core/dom/Node.cpp ('k') | Source/core/svg/SVGUseElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698