Unifies LayerTreeHost::SetNeedsUpdateLayers and SetNeedsAnimate

content/renderer/gpu/render_widget_compositor.cc

Index: content/renderer/gpu/render_widget_compositor.cc
diff --git a/content/renderer/gpu/render_widget_compositor.cc b/content/renderer/gpu/render_widget_compositor.cc
index 760604bfcbddb560dcc8d7db53f8c2aae22dfa0a..9d7b116d7c270a0fd8d764f95d1d410ffa7231a7 100644
--- a/content/renderer/gpu/render_widget_compositor.cc
+++ b/content/renderer/gpu/render_widget_compositor.cc
@@ -502,21 +502,18 @@ void RenderWidgetCompositor::startPageScaleAnimation(
       duration);
 }
 
-void RenderWidgetCompositor::setNeedsAnimate() {
-  layer_tree_host_->SetNeedsAnimate();
+void RenderWidgetCompositor::setNeedsUpdateLayers() {
+  layer_tree_host_->SetNeedsUpdateLayers();
 }
 
 void RenderWidgetCompositor::setNeedsRedraw() {
+  // TODO(trchen): This function is not doing what the name indicates?

[jamesr, 2013/11/19 00:54:26]

the purpose of this function is to request that whichever system is in control
of scheduling frames kick another one.  In single-threaded mode, that's the
RenderWidget so this calls RenderWidget::scheduleAnimation().  In threaded mode,
it's the scheduler inside cc so this calls cc::SetNeedsAnimate().  Both have the
practical effect of kicking the make-a-frame logic without causing any specific
damage.

It sounds like this is exactly the semantics you want with
SetNeedsUpdateLayers()

I don't think TODO is at all beneficial to have in the code

   if (threaded_)
-    layer_tree_host_->SetNeedsAnimate();
+    layer_tree_host_->SetNeedsUpdateLayers();
   else
     widget_->scheduleAnimation();
 }
 
-bool RenderWidgetCompositor::commitRequested() const {
-  return layer_tree_host_->CommitRequested();
-}
-
 void RenderWidgetCompositor::didStopFlinging() {
   layer_tree_host_->DidStopFlinging();
 }