Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 68893013: Fix socket usage in forwarder2. (Closed)

Created:
7 years, 1 month ago by Philippe
Modified:
7 years, 1 month ago
Reviewers:
bulach, digit1
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Fix socket usage in forwarder2. This fixes the use of *blocking* sockets in a non-blocking fashion (with select()) and adds the new NonBlocking{Read,Write}() methods that will be used in a follow-up CL. BUG=313809 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234937

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -20 lines) Patch
M tools/android/forwarder2/socket.h View 2 chunks +11 lines, -1 line 0 comments Download
M tools/android/forwarder2/socket.cc View 8 chunks +60 lines, -19 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Philippe
FYI, this is a preliminary CL. Marcus, remember that place with the select() appearing to ...
7 years, 1 month ago (2013-11-13 09:45:52 UTC) #1
digit1
lgtm
7 years, 1 month ago (2013-11-13 10:28:36 UTC) #2
digit1
https://codereview.chromium.org/68893013/diff/1/tools/android/forwarder2/socket.cc File tools/android/forwarder2/socket.cc (right): https://codereview.chromium.org/68893013/diff/1/tools/android/forwarder2/socket.cc#newcode335 tools/android/forwarder2/socket.cc:335: DCHECK(fcntl(socket_, F_GETFL) & O_NONBLOCK); I really like this DCHECK(), ...
7 years, 1 month ago (2013-11-13 10:28:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/68893013/1
7 years, 1 month ago (2013-11-13 14:55:13 UTC) #4
commit-bot: I haz the power
Change committed as 234937
7 years, 1 month ago (2013-11-13 22:44:51 UTC) #5
bulach
7 years, 1 month ago (2013-11-14 16:57:30 UTC) #6
Message was sent while issue was closed.
lgtm (sorry, was perf sheriffing...)

Powered by Google App Engine
This is Rietveld 408576698