Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 68893003: Move NSScrollerImpDetails to platform/mac/ (Closed)

Created:
7 years, 1 month ago by pilgrim_google
Modified:
7 years ago
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers, darin (slow to review)
Visibility:
Public.

Description

Move NSScrollerImpDetails to platform/mac/ BUG=297477

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -225 lines) Patch
M Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/platform/ScrollbarThemeMacCommon.mm View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/ScrollbarThemeMacOverlayAPI.mm View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/platform/mac/NSScrollerImpDetails.h View 1 chunk +0 lines, -119 lines 0 comments Download
D Source/core/platform/mac/NSScrollerImpDetails.mm View 1 chunk +0 lines, -95 lines 0 comments Download
M Source/core/platform/mac/ScrollAnimatorMac.mm View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A + Source/platform/mac/NSScrollerImpDetails.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + Source/platform/mac/NSScrollerImpDetails.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
pilgrim_google
7 years, 1 month ago (2013-11-11 16:11:25 UTC) #1
eseidel
I thought Avi had recently inverted this logic so that the browser told us about ...
7 years, 1 month ago (2013-11-11 18:34:59 UTC) #2
Avi (use Gerrit)
On 2013/11/11 18:34:59, eseidel wrote: > I thought Avi had recently inverted this logic so ...
7 years, 1 month ago (2013-11-11 18:59:50 UTC) #3
pilgrim_google
This file compiled when it was in core/platform/ but fails now in platform/ , which ...
7 years, 1 month ago (2013-11-12 14:51:38 UTC) #4
pilgrim_google
Bump.
7 years ago (2013-12-09 14:51:45 UTC) #5
abarth-chromium
No logs here either...
7 years ago (2013-12-09 17:36:01 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years ago (2013-12-09 17:36:07 UTC) #7
eseidel
I suspect all of this stuff should be in rendering/mac along with RenderTheme instead of ...
7 years ago (2013-12-09 18:19:38 UTC) #8
eseidel
7 years ago (2013-12-09 18:19:59 UTC) #9
lgtm

Powered by Google App Engine
This is Rietveld 408576698