Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 688883002: Revert of Add Search Service in Enhanced Bookmark Bridge (Closed)

Created:
6 years, 1 month ago by Ken Russell (switch to Gerrit)
Modified:
5 years, 2 months ago
CC:
chromium-reviews, Mark
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Add Search Service in Enhanced Bookmark Bridge (patchset #6 id:100001 of https://codereview.chromium.org/637323005/) Reason for revert: Broke compilation in http://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%207%29/builds/14002 Original issue's description: > Add Search Service in Enhanced Bookmark Bridge > > A Search client is created during initialization of > EnhancedBookmarkBridge. And when the bridge destructs, search service is > also destroyed. > > BUG=415774 > > Committed: https://crrev.com/e52346f194e9f2d097b4f6d3fbfa359eca7c92df > Cr-Commit-Position: refs/heads/master@{#302107} TBR=tedchoc@chromium.org,danduong@chromium.org,kkimlabs@chromium.org,noyau@chromium.org,lpromero@chromium.org,ianwen@chromium.org NOTREECHECKS=true NOTRY=true BUG=415774 Committed: https://crrev.com/1491f336d849dcf168cc8832e91a7c8213dd2a7f Cr-Commit-Position: refs/heads/master@{#302130}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -182 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/EnhancedBookmarksBridge.java View 7 chunks +7 lines, -69 lines 0 comments Download
M chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h View 3 chunks +3 lines, -11 lines 0 comments Download
M chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc View 6 chunks +3 lines, -45 lines 0 comments Download
M components/enhanced_bookmarks/bookmark_server_search_service.h View 3 chunks +8 lines, -18 lines 0 comments Download
M components/enhanced_bookmarks/bookmark_server_search_service.cc View 4 chunks +23 lines, -31 lines 0 comments Download
M components/enhanced_bookmarks/bookmark_server_service.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/enhanced_bookmarks/bookmark_server_service.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Russell (switch to Gerrit)
Created Revert of Add Search Service in Enhanced Bookmark Bridge
6 years, 1 month ago (2014-10-30 19:19:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688883002/1
6 years, 1 month ago (2014-10-30 19:20:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 19:22:54 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 19:23:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1491f336d849dcf168cc8832e91a7c8213dd2a7f
Cr-Commit-Position: refs/heads/master@{#302130}

Powered by Google App Engine
This is Rietveld 408576698