Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: extensions/components/javascript_dialog_extensions_client/javascript_dialog_extension_client_impl.cc

Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/components/javascript_dialog_extensions_client/javascript_dialog_extension_client_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/components/javascript_dialog_extensions_client/javascript_dialog_extension_client_impl.cc
diff --git a/extensions/components/javascript_dialog_extensions_client/javascript_dialog_extension_client_impl.cc b/extensions/components/javascript_dialog_extensions_client/javascript_dialog_extension_client_impl.cc
index ddf02725f95ccc5cf0ba6ce237b1daa8d3eca77c..f50b4e98560c45d32ffdba959c4b46a4b7f2621a 100644
--- a/extensions/components/javascript_dialog_extensions_client/javascript_dialog_extension_client_impl.cc
+++ b/extensions/components/javascript_dialog_extensions_client/javascript_dialog_extension_client_impl.cc
@@ -11,6 +11,7 @@
#include "extensions/common/extension.h"
#include "ui/gfx/native_widget_types.h"
+namespace javascript_dialog_extensions_client {
namespace {
using extensions::Extension;
@@ -30,7 +31,7 @@ const Extension* GetExtensionForWebContents(
}
class JavaScriptDialogExtensionsClientImpl
- : public JavaScriptDialogExtensionsClient {
+ : public app_modal::JavaScriptDialogExtensionsClient {
public:
JavaScriptDialogExtensionsClientImpl() {}
~JavaScriptDialogExtensionsClientImpl() override {}
@@ -74,7 +75,10 @@ class JavaScriptDialogExtensionsClientImpl
} // namespace
-void InstallJavaScriptDialogExtensionsClient() {
- SetJavaScriptDialogExtensionsClient(
- make_scoped_ptr(new JavaScriptDialogExtensionsClientImpl));
+void InstallClient() {
+ app_modal::JavaScriptDialogManager::GetInstance()->
+ SetExtensionsClient(
+ make_scoped_ptr(new JavaScriptDialogExtensionsClientImpl));
}
+
+} // namespace javascript_dialog_extensions_client
« no previous file with comments | « extensions/components/javascript_dialog_extensions_client/javascript_dialog_extension_client_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698