Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: components/app_modal/javascript_dialog_manager.h

Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/app_modal/javascript_dialog_manager.h
diff --git a/components/app_modal/javascript_dialog_manager.h b/components/app_modal/javascript_dialog_manager.h
index 88aa78c9ecf2ce2a9843e473a173886e784b45b4..83720151b5ebbb1ee97f4bcc061c7e15492a8e84 100644
--- a/components/app_modal/javascript_dialog_manager.h
+++ b/components/app_modal/javascript_dialog_manager.h
@@ -6,28 +6,82 @@
#define COMPONENTS_APP_MODAL_JAVASCRIPT_DIALOG_MANAGER_H_
#include "base/memory/scoped_ptr.h"
+#include "base/memory/singleton.h"
+#include "components/app_modal/javascript_app_modal_dialog.h"
+#include "content/public/browser/javascript_dialog_manager.h"
-namespace content {
-class JavaScriptDialogManager;
-}
+namespace app_modal {
class JavaScriptDialogExtensionsClient;
class JavaScriptNativeDialogFactory;
-// Returns a JavaScriptDialogManager that creates real dialogs.
-// It returns a Singleton instance of JavaScriptDialogManager,
-// which should not be deleted.
-content::JavaScriptDialogManager* GetJavaScriptDialogManagerInstance();
-
-// Sets the JavaScriptNativeDialogFactory used to create platform specific
-// dialog window implementation.
-void SetJavaScriptNativeDialogFactory(
- scoped_ptr<JavaScriptNativeDialogFactory> factory);
-
-// JavaScript dialog may be opened by an extensions/app, thus needs
-// access to extensions functionality. This sets a client interface to
-// access //extensions.
-void SetJavaScriptDialogExtensionsClient(
- scoped_ptr<JavaScriptDialogExtensionsClient> client);
+class JavaScriptDialogManager : public content::JavaScriptDialogManager {
+ public:
+ static JavaScriptDialogManager* GetInstance();
+
+ JavaScriptNativeDialogFactory* native_dialog_factory() {
+ return native_dialog_factory_.get();
+ }
+
+ // Sets the JavaScriptNativeDialogFactory used to create platform specific
+ // dialog window instances.
+ void SetNativeDialogFactory(
+ scoped_ptr<JavaScriptNativeDialogFactory> factory);
+
+ // JavaScript dialogs may be opened by an extensions/app, thus they need
+ // access to extensions functionality. This sets a client interface to
+ // access //extensions.
+ void SetExtensionsClient(
+ scoped_ptr<JavaScriptDialogExtensionsClient> extensions_client);
+
+ private:
+ friend struct DefaultSingletonTraits<JavaScriptDialogManager>;
+
+ JavaScriptDialogManager();
+ ~JavaScriptDialogManager() override;
+
+ // JavaScriptDialogManager:
+ void RunJavaScriptDialog(content::WebContents* web_contents,
+ const GURL& origin_url,
+ const std::string& accept_lang,
+ content::JavaScriptMessageType message_type,
+ const base::string16& message_text,
+ const base::string16& default_prompt_text,
+ const DialogClosedCallback& callback,
+ bool* did_suppress_message) override;
+ void RunBeforeUnloadDialog(content::WebContents* web_contents,
+ const base::string16& message_text,
+ bool is_reload,
+ const DialogClosedCallback& callback) override;
+ bool HandleJavaScriptDialog(content::WebContents* web_contents,
+ bool accept,
+ const base::string16* prompt_override) override;
+ void CancelActiveAndPendingDialogs(
+ content::WebContents* web_contents) override;
+ void WebContentsDestroyed(content::WebContents* web_contents) override;
+
+ base::string16 GetTitle(content::WebContents* web_contents,
+ const GURL& origin_url,
+ const std::string& accept_lang,
+ bool is_alert);
+
+ // Wrapper around a DialogClosedCallback so that we can intercept it before
+ // passing it onto the original callback.
+ void OnDialogClosed(content::WebContents* web_contents,
+ DialogClosedCallback callback,
+ bool success,
+ const base::string16& user_input);
+
+ // Mapping between the WebContents and their extra data. The key
+ // is a void* because the pointer is just a cookie and is never dereferenced.
+ JavaScriptAppModalDialog::ExtraDataMap javascript_dialog_extra_data_;
+
+ scoped_ptr<JavaScriptNativeDialogFactory> native_dialog_factory_;
+ scoped_ptr<JavaScriptDialogExtensionsClient> extensions_client_;
+
+ DISALLOW_COPY_AND_ASSIGN(JavaScriptDialogManager);
+};
+
+} // namespace app_modal
#endif // COMPONENTS_APP_MODAL_JAVASCRIPT_DIALOG_MANAGER_H_
« no previous file with comments | « components/app_modal/javascript_dialog_extensions_client.h ('k') | components/app_modal/javascript_dialog_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698