components/app_modal/BUILD.gn - Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/app_modal/BUILD.gn

Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/app_modal/BUILD.gn

diff --git a/components/app_modal/BUILD.gn b/components/app_modal/BUILD.gn

index 26df1dffd3418ea50ffe0f544b8746584efb6538..a2d373d28a33b6cafbfa40719ddfd296bc0c600b 100644

--- a/components/app_modal/BUILD.gn

+++ b/components/app_modal/BUILD.gn

@@ -15,8 +15,6 @@ static_library("app_modal") {

"javascript_dialog_extension_client.h",

"javascript_dialog_manager.cc",

"javascript_dialog_manager.h",

- "javascript_dialog_manager_impl.cc",

- "javascript_dialog_manager_impl.h",

"javascript_native_dialog_factory.h",

"native_app_modal_dialog.h"

]

« no previous file with comments | « components/app_modal.gypi ('k') | components/app_modal/app_modal_dialog.h » ('j') | no next file with comments »