athena/extensions/extensions_delegate.cc - Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/extensions/extensions_delegate.cc

Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « athena/extensions/athena_javascript_native_dialog_factory.cc ('k') | chrome/browser/android/chrome_web_contents_delegate_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: athena/extensions/extensions_delegate.cc

diff --git a/athena/extensions/extensions_delegate.cc b/athena/extensions/extensions_delegate.cc

index 00a93b96d990e585df76e9ad5a9a696cc38d9dc0..823a15940f5bac0b789df719d78f34df7f22c62f 100644

--- a/athena/extensions/extensions_delegate.cc

+++ b/athena/extensions/extensions_delegate.cc

@@ -18,7 +18,7 @@ ExtensionsDelegate* instance = nullptr;

ExtensionsDelegate::ExtensionsDelegate() {

InstallConstrainedWindowViewsClient();

- InstallJavaScriptDialogExtensionsClient();

+ javascript_dialog_extensions_client::InstallClient();

InstallJavaScriptNativeDialogFactory();

DCHECK(!instance);

instance = this;