Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3020)

Unified Diff: athena/extensions/athena_javascript_native_dialog_factory.cc

Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: namespace Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « athena/content/web_activity.cc ('k') | athena/extensions/extensions_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: athena/extensions/athena_javascript_native_dialog_factory.cc
diff --git a/athena/extensions/athena_javascript_native_dialog_factory.cc b/athena/extensions/athena_javascript_native_dialog_factory.cc
index 6883a9e5360a9435505ca487b2891396bfb93d3a..8806ecc16eaa37c6babdaa7377eff255c93d4566 100644
--- a/athena/extensions/athena_javascript_native_dialog_factory.cc
+++ b/athena/extensions/athena_javascript_native_dialog_factory.cc
@@ -17,18 +17,18 @@ namespace athena {
namespace {
class AthenaJavaScriptNativeDialogFactory
- : public JavaScriptNativeDialogFactory {
+ : public app_modal_dialogs::JavaScriptNativeDialogFactory {
public:
AthenaJavaScriptNativeDialogFactory() {}
~AthenaJavaScriptNativeDialogFactory() override {}
private:
// JavScriptNativeDialogFactory:
msw 2014/11/11 08:34:53 nit: app_modal_dialogs:: namespace in comment.
oshima 2014/11/11 18:19:48 Done.
- NativeAppModalDialog* CreateNativeJavaScriptDialog(
- JavaScriptAppModalDialog* dialog,
+ app_modal_dialogs::NativeAppModalDialog* CreateNativeJavaScriptDialog(
+ app_modal_dialogs::JavaScriptAppModalDialog* dialog,
gfx::NativeWindow parent_window) override{
- JavaScriptAppModalDialogViews* d =
- new JavaScriptAppModalDialogViews(dialog);
+ app_modal_dialogs::JavaScriptAppModalDialogViews* d =
+ new app_modal_dialogs::JavaScriptAppModalDialogViews(dialog);
CreateBrowserModalDialogViews(d, parent_window);
return d;
}
@@ -39,8 +39,9 @@ class AthenaJavaScriptNativeDialogFactory
} // namespace
void InstallJavaScriptNativeDialogFactory() {
- SetJavaScriptNativeDialogFactory(
- make_scoped_ptr(new AthenaJavaScriptNativeDialogFactory));
+ app_modal_dialogs::JavaScriptDialogManager::GetInstance()->
+ SetNativeDialogFactory(
+ make_scoped_ptr(new AthenaJavaScriptNativeDialogFactory));
}
} // namespace athena
« no previous file with comments | « athena/content/web_activity.cc ('k') | athena/extensions/extensions_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698