extensions/components/javascript_dialog_extensions_client/javascript_dialog_extension_client_impl.cc - Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/components/javascript_dialog_extensions_client/javascript_dialog_extension_client_impl.cc

Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/components/javascript_dialog_extensions_client/javascript_dialog_extension_client_impl.cc

diff --git a/extensions/components/javascript_dialog_extensions_client/javascript_dialog_extension_client_impl.cc b/extensions/components/javascript_dialog_extensions_client/javascript_dialog_extension_client_impl.cc

index 5522b54dbe7384c784ff961b3ca3c3bbf12fd2ef..501b514b2b35f92e88497e630171f6d66d6302e2 100644

--- a/extensions/components/javascript_dialog_extensions_client/javascript_dialog_extension_client_impl.cc

+++ b/extensions/components/javascript_dialog_extensions_client/javascript_dialog_extension_client_impl.cc

@@ -75,6 +75,6 @@ class JavaScriptDialogExtensionsClientImpl

} // namespace

void InstallJavaScriptDialogExtensionsClient() {

- SetJavaScriptDialogExtensionsClient(

+ JavaScriptDialogManager::GetInstance()->SetExtensionsClient(

make_scoped_ptr(new JavaScriptDialogExtensionsClientImpl));

}

« components/app_modal_dialogs/javascript_dialog_manager.h ('K') | « components/app_modal_dialogs/javascript_dialog_manager_impl.cc ('k') | no next file » | no next file with comments »