chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc - Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc

Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc

diff --git a/chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc b/chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc

index 8a40a2ff9ec09ef12477c3e38f666071b47771dc..a938841708f4d544b22df48aaafdb1a6df39158d 100644

--- a/chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc

+++ b/chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc

@@ -42,6 +42,6 @@ class ChromeJavaScriptNativeDialogViewsFactory

} // namespace

void InstallChromeJavaScriptNativeDialogFactory() {

- SetJavaScriptNativeDialogFactory(

+ JavaScriptDialogManager::GetInstance()->SetNativeDialogFactory(

make_scoped_ptr(new ChromeJavaScriptNativeDialogViewsFactory));

}

« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | components/app_modal_dialogs.gypi » ('j') | components/app_modal_dialogs/javascript_dialog_manager.h » ('J')