Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc

Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/app_modal/chrome_javascript_native_dialog_factory.h" 5 #include "chrome/browser/ui/app_modal/chrome_javascript_native_dialog_factory.h"
6 6
7 #include "components/app_modal/javascript_dialog_manager.h" 7 #include "components/app_modal/javascript_dialog_manager.h"
8 #include "components/app_modal/javascript_native_dialog_factory.h" 8 #include "components/app_modal/javascript_native_dialog_factory.h"
9 #include "components/constrained_window/constrained_window_views.h" 9 #include "components/constrained_window/constrained_window_views.h"
10 10
11 #if defined(USE_X11) && !defined(OS_CHROMEOS) 11 #if defined(USE_X11) && !defined(OS_CHROMEOS)
12 #include "chrome/browser/ui/views/javascript_app_modal_dialog_views_x11.h" 12 #include "chrome/browser/ui/views/javascript_app_modal_dialog_views_x11.h"
13 #else 13 #else
14 #include "components/app_modal/views/javascript_app_modal_dialog_views.h" 14 #include "components/app_modal/views/javascript_app_modal_dialog_views.h"
15 #endif 15 #endif
16 16
17 namespace { 17 namespace {
18 18
19 class ChromeJavaScriptNativeDialogViewsFactory 19 class ChromeJavaScriptNativeDialogViewsFactory
20 : public JavaScriptNativeDialogFactory { 20 : public app_modal::JavaScriptNativeDialogFactory {
21 public: 21 public:
22 ChromeJavaScriptNativeDialogViewsFactory() {} 22 ChromeJavaScriptNativeDialogViewsFactory() {}
23 ~ChromeJavaScriptNativeDialogViewsFactory() override {} 23 ~ChromeJavaScriptNativeDialogViewsFactory() override {}
24 24
25 private: 25 private:
26 NativeAppModalDialog* CreateNativeJavaScriptDialog( 26 app_modal::NativeAppModalDialog* CreateNativeJavaScriptDialog(
27 JavaScriptAppModalDialog* dialog, 27 app_modal::JavaScriptAppModalDialog* dialog,
28 gfx::NativeWindow parent_window) override{ 28 gfx::NativeWindow parent_window) override{
29 JavaScriptAppModalDialogViews* d = nullptr; 29 app_modal::JavaScriptAppModalDialogViews* d = nullptr;
30 #if defined(USE_X11) && !defined(OS_CHROMEOS) 30 #if defined(USE_X11) && !defined(OS_CHROMEOS)
31 d = new JavaScriptAppModalDialogViewsX11(dialog); 31 d = new JavaScriptAppModalDialogViewsX11(dialog);
32 #else 32 #else
33 d = new JavaScriptAppModalDialogViews(dialog); 33 d = new app_modal::JavaScriptAppModalDialogViews(dialog);
34 #endif 34 #endif
35 constrained_window::CreateBrowserModalDialogViews(d, parent_window); 35 constrained_window::CreateBrowserModalDialogViews(d, parent_window);
36 return d; 36 return d;
37 } 37 }
38 38
39 DISALLOW_COPY_AND_ASSIGN(ChromeJavaScriptNativeDialogViewsFactory); 39 DISALLOW_COPY_AND_ASSIGN(ChromeJavaScriptNativeDialogViewsFactory);
40 }; 40 };
41 41
42 } // namespace 42 } // namespace
43 43
44 void InstallChromeJavaScriptNativeDialogFactory() { 44 void InstallChromeJavaScriptNativeDialogFactory() {
45 SetJavaScriptNativeDialogFactory( 45 app_modal::JavaScriptDialogManager::GetInstance()->
46 make_scoped_ptr(new ChromeJavaScriptNativeDialogViewsFactory)); 46 SetNativeDialogFactory(
47 make_scoped_ptr(new ChromeJavaScriptNativeDialogViewsFactory));
47 } 48 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698