Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Side by Side Diff: chrome/browser/ui/android/javascript_app_modal_dialog_android.cc

Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/android/javascript_app_modal_dialog_android.h" 5 #include "chrome/browser/ui/android/javascript_app_modal_dialog_android.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_string.h" 8 #include "base/android/jni_string.h"
9 #include "chrome/browser/ui/app_modal/chrome_javascript_native_dialog_factory.h" 9 #include "chrome/browser/ui/app_modal/chrome_javascript_native_dialog_factory.h"
10 #include "components/app_modal/app_modal_dialog_queue.h" 10 #include "components/app_modal/app_modal_dialog_queue.h"
11 #include "components/app_modal/javascript_app_modal_dialog.h" 11 #include "components/app_modal/javascript_app_modal_dialog.h"
12 #include "components/app_modal/javascript_dialog_manager.h" 12 #include "components/app_modal/javascript_dialog_manager.h"
13 #include "components/app_modal/javascript_native_dialog_factory.h" 13 #include "components/app_modal/javascript_native_dialog_factory.h"
14 #include "content/public/browser/browser_thread.h" 14 #include "content/public/browser/browser_thread.h"
15 #include "content/public/common/javascript_message_type.h" 15 #include "content/public/common/javascript_message_type.h"
16 #include "jni/JavascriptAppModalDialog_jni.h" 16 #include "jni/JavascriptAppModalDialog_jni.h"
17 #include "ui/base/android/window_android.h" 17 #include "ui/base/android/window_android.h"
18 18
19 using base::android::AttachCurrentThread; 19 using base::android::AttachCurrentThread;
20 using base::android::ConvertUTF16ToJavaString; 20 using base::android::ConvertUTF16ToJavaString;
21 using base::android::ScopedJavaGlobalRef; 21 using base::android::ScopedJavaGlobalRef;
22 using base::android::ScopedJavaLocalRef; 22 using base::android::ScopedJavaLocalRef;
23 23
24 JavascriptAppModalDialogAndroid::JavascriptAppModalDialogAndroid( 24 JavascriptAppModalDialogAndroid::JavascriptAppModalDialogAndroid(
25 JNIEnv* env, 25 JNIEnv* env,
26 JavaScriptAppModalDialog* dialog, 26 app_modal::JavaScriptAppModalDialog* dialog,
27 gfx::NativeWindow parent) 27 gfx::NativeWindow parent)
28 : dialog_(dialog), 28 : dialog_(dialog),
29 parent_jobject_weak_ref_(env, parent->GetJavaObject().obj()) { 29 parent_jobject_weak_ref_(env, parent->GetJavaObject().obj()) {
30 } 30 }
31 31
32 int JavascriptAppModalDialogAndroid::GetAppModalDialogButtons() const { 32 int JavascriptAppModalDialogAndroid::GetAppModalDialogButtons() const {
33 NOTIMPLEMENTED(); 33 NOTIMPLEMENTED();
34 return 0; 34 return 0;
35 } 35 }
36 36
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 delete this; 124 delete this;
125 } 125 }
126 126
127 const ScopedJavaGlobalRef<jobject>& 127 const ScopedJavaGlobalRef<jobject>&
128 JavascriptAppModalDialogAndroid::GetDialogObject() const { 128 JavascriptAppModalDialogAndroid::GetDialogObject() const {
129 return dialog_jobject_; 129 return dialog_jobject_;
130 } 130 }
131 131
132 // static 132 // static
133 jobject GetCurrentModalDialog(JNIEnv* env, jclass clazz) { 133 jobject GetCurrentModalDialog(JNIEnv* env, jclass clazz) {
134 AppModalDialog* dialog = AppModalDialogQueue::GetInstance()->active_dialog(); 134 app_modal::AppModalDialog* dialog =
135 app_modal::AppModalDialogQueue::GetInstance()->active_dialog();
135 if (!dialog || !dialog->native_dialog()) 136 if (!dialog || !dialog->native_dialog())
136 return NULL; 137 return NULL;
137 138
138 JavascriptAppModalDialogAndroid* js_dialog = 139 JavascriptAppModalDialogAndroid* js_dialog =
139 static_cast<JavascriptAppModalDialogAndroid*>(dialog->native_dialog()); 140 static_cast<JavascriptAppModalDialogAndroid*>(dialog->native_dialog());
140 return js_dialog->GetDialogObject().obj(); 141 return js_dialog->GetDialogObject().obj();
141 } 142 }
142 143
143 // static 144 // static
144 bool JavascriptAppModalDialogAndroid::RegisterJavascriptAppModalDialog( 145 bool JavascriptAppModalDialogAndroid::RegisterJavascriptAppModalDialog(
145 JNIEnv* env) { 146 JNIEnv* env) {
146 return RegisterNativesImpl(env); 147 return RegisterNativesImpl(env);
147 } 148 }
148 149
149 JavascriptAppModalDialogAndroid::~JavascriptAppModalDialogAndroid() { 150 JavascriptAppModalDialogAndroid::~JavascriptAppModalDialogAndroid() {
150 // In case the dialog is still displaying, tell it to close itself. 151 // In case the dialog is still displaying, tell it to close itself.
151 // This can happen if you trigger a dialog but close the Tab before it's 152 // This can happen if you trigger a dialog but close the Tab before it's
152 // shown, and then accept the dialog. 153 // shown, and then accept the dialog.
153 if (!dialog_jobject_.is_null()) { 154 if (!dialog_jobject_.is_null()) {
154 JNIEnv* env = AttachCurrentThread(); 155 JNIEnv* env = AttachCurrentThread();
155 Java_JavascriptAppModalDialog_dismiss(env, dialog_jobject_.obj()); 156 Java_JavascriptAppModalDialog_dismiss(env, dialog_jobject_.obj());
156 } 157 }
157 } 158 }
158 159
159 namespace { 160 namespace {
160 161
161 class ChromeJavaScriptNativeDialogAndroidFactory 162 class ChromeJavaScriptNativeDialogAndroidFactory
162 : public JavaScriptNativeDialogFactory { 163 : public app_modal::JavaScriptNativeDialogFactory {
163 public: 164 public:
164 ChromeJavaScriptNativeDialogAndroidFactory() {} 165 ChromeJavaScriptNativeDialogAndroidFactory() {}
165 ~ChromeJavaScriptNativeDialogAndroidFactory() override {} 166 ~ChromeJavaScriptNativeDialogAndroidFactory() override {}
166 167
167 private: 168 private:
168 NativeAppModalDialog* CreateNativeJavaScriptDialog( 169 app_modal::NativeAppModalDialog* CreateNativeJavaScriptDialog(
169 JavaScriptAppModalDialog* dialog, 170 app_modal::JavaScriptAppModalDialog* dialog,
170 gfx::NativeWindow parent_window) override { 171 gfx::NativeWindow parent_window) override {
171 return new JavascriptAppModalDialogAndroid( 172 return new JavascriptAppModalDialogAndroid(
172 base::android::AttachCurrentThread(), 173 base::android::AttachCurrentThread(),
173 dialog, parent_window); 174 dialog, parent_window);
174 } 175 }
175 176
176 DISALLOW_COPY_AND_ASSIGN(ChromeJavaScriptNativeDialogAndroidFactory); 177 DISALLOW_COPY_AND_ASSIGN(ChromeJavaScriptNativeDialogAndroidFactory);
177 }; 178 };
178 179
179 } // namespace 180 } // namespace
180 181
181 void InstallChromeJavaScriptNativeDialogFactory() { 182 void InstallChromeJavaScriptNativeDialogFactory() {
182 SetJavaScriptNativeDialogFactory( 183 app_modal::JavaScriptDialogManager::GetInstance()->
183 make_scoped_ptr(new ChromeJavaScriptNativeDialogAndroidFactory)); 184 SetNativeDialogFactory(
185 make_scoped_ptr(new ChromeJavaScriptNativeDialogAndroidFactory));
184 } 186 }
185 187
OLDNEW
« no previous file with comments | « chrome/browser/ui/android/javascript_app_modal_dialog_android.h ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698