Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: chrome/browser/extensions/chrome_extension_host_delegate.cc

Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/chrome_extension_host_delegate.h" 5 #include "chrome/browser/extensions/chrome_extension_host_delegate.h"
6 6
7 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h" 7 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
8 #include "chrome/browser/extensions/extension_service.h" 8 #include "chrome/browser/extensions/extension_service.h"
9 #include "chrome/browser/extensions/extension_tab_util.h" 9 #include "chrome/browser/extensions/extension_tab_util.h"
10 #include "chrome/browser/media/media_capture_devices_dispatcher.h" 10 #include "chrome/browser/media/media_capture_devices_dispatcher.h"
(...skipping 17 matching lines...) Expand all
28 void ChromeExtensionHostDelegate::OnRenderViewCreatedForBackgroundPage( 28 void ChromeExtensionHostDelegate::OnRenderViewCreatedForBackgroundPage(
29 ExtensionHost* host) { 29 ExtensionHost* host) {
30 ExtensionService* service = 30 ExtensionService* service =
31 ExtensionSystem::Get(host->browser_context())->extension_service(); 31 ExtensionSystem::Get(host->browser_context())->extension_service();
32 if (service) 32 if (service)
33 service->DidCreateRenderViewForBackgroundPage(host); 33 service->DidCreateRenderViewForBackgroundPage(host);
34 } 34 }
35 35
36 content::JavaScriptDialogManager* 36 content::JavaScriptDialogManager*
37 ChromeExtensionHostDelegate::GetJavaScriptDialogManager() { 37 ChromeExtensionHostDelegate::GetJavaScriptDialogManager() {
38 return GetJavaScriptDialogManagerInstance(); 38 return app_modal::JavaScriptDialogManager::GetInstance();
39 } 39 }
40 40
41 void ChromeExtensionHostDelegate::CreateTab(content::WebContents* web_contents, 41 void ChromeExtensionHostDelegate::CreateTab(content::WebContents* web_contents,
42 const std::string& extension_id, 42 const std::string& extension_id,
43 WindowOpenDisposition disposition, 43 WindowOpenDisposition disposition,
44 const gfx::Rect& initial_pos, 44 const gfx::Rect& initial_pos,
45 bool user_gesture) { 45 bool user_gesture) {
46 ExtensionTabUtil::CreateTab( 46 ExtensionTabUtil::CreateTab(
47 web_contents, extension_id, disposition, initial_pos, user_gesture); 47 web_contents, extension_id, disposition, initial_pos, user_gesture);
48 } 48 }
(...skipping 11 matching lines...) Expand all
60 content::WebContents* web_contents, 60 content::WebContents* web_contents,
61 const GURL& security_origin, 61 const GURL& security_origin,
62 content::MediaStreamType type, 62 content::MediaStreamType type,
63 const Extension* extension) { 63 const Extension* extension) {
64 return MediaCaptureDevicesDispatcher::GetInstance() 64 return MediaCaptureDevicesDispatcher::GetInstance()
65 ->CheckMediaAccessPermission( 65 ->CheckMediaAccessPermission(
66 web_contents, security_origin, type, extension); 66 web_contents, security_origin, type, extension);
67 } 67 }
68 68
69 } // namespace extensions 69 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/alert_apitest.cc ('k') | chrome/browser/extensions/lazy_background_page_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698