Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h

components/app_modal_dialogs/javascript_dialog_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_APP_MODAL_DIALOGS_JAVASCRIPT_DIALOG_MANAGER_H_
 #define COMPONENTS_APP_MODAL_DIALOGS_JAVASCRIPT_DIALOG_MANAGER_H_
 
 #include "base/memory/scoped_ptr.h"
-
-namespace content {
-class JavaScriptDialogManager;
-}
+#include "base/memory/singleton.h"
+#include "components/app_modal_dialogs/javascript_app_modal_dialog.h"
+#include "content/public/browser/javascript_dialog_manager.h"
 
 class JavaScriptDialogExtensionsClient;
 class JavaScriptNativeDialogFactory;
 
-// Returns a JavaScriptDialogManager that creates real dialogs.
-// It returns a Singleton instance of JavaScriptDialogManager,
-// which should not be deleted.
-content::JavaScriptDialogManager* GetJavaScriptDialogManagerInstance();
+class JavaScriptDialogManager : public content::JavaScriptDialogManager {
+ public:
+  static JavaScriptDialogManager* GetInstance();
 
-// Sets the JavaScriptNativeDialogFactory used to create platform specific
-// dialog window implementation.
-void SetJavaScriptNativeDialogFactory(
-    scoped_ptr<JavaScriptNativeDialogFactory> factory);
+  // Sets the JavaScriptNativeDialogFactory used to create platform specific
+  // dialog window implementation.
+  void SetNativeDialogFactory(
+      scoped_ptr<JavaScriptNativeDialogFactory> factory);
 
-// JavaScript dialog may be opened by an extensions/app, thus needs
-// access to extensions functionality. This sets a client interface to
-// access //extensions.
-void SetJavaScriptDialogExtensionsClient(
-    scoped_ptr<JavaScriptDialogExtensionsClient> client);
+  // JavaScript dialog may be opened by an extensions/app, thus needs

[msw, 2014/11/06 17:12:39]

nit: consider "Set an |extension_client| to provide access to //extensions for
JavaScript dialogs that are opened by an extension or an app."

+  // access to extensions functionality. This sets a client interface to
+  // access //extensions.
+  void SetExtensionsClient(
+      scoped_ptr<JavaScriptDialogExtensionsClient> extensions_client);
+
+  JavaScriptNativeDialogFactory* native_dialog_factory() {

[msw, 2014/11/06 17:12:39]

nit: reorder adjacent to SetNativeDialogFactory, which I think may be inlined:
  void set_native_dialog_factory(
      scoped_ptr<JavaScriptNativeDialogFactory> factory) {
    native_dialog_factory_ = factory.Pass();
  }

[oshima, 2014/11/06 18:05:53]

reordered.
That requires inclusion of javascript_native_dialog_factory.h.

+    return native_dialog_factory_.get();
+  }
+
+ private:
+  friend struct DefaultSingletonTraits<JavaScriptDialogManager>;
+
+  JavaScriptDialogManager();
+  ~JavaScriptDialogManager() override;
+
+  // JavaScriptDialogManager:
+  void RunJavaScriptDialog(content::WebContents* web_contents,
+                           const GURL& origin_url,
+                           const std::string& accept_lang,
+                           content::JavaScriptMessageType message_type,
+                           const base::string16& message_text,
+                           const base::string16& default_prompt_text,
+                           const DialogClosedCallback& callback,
+                           bool* did_suppress_message) override;
+  void RunBeforeUnloadDialog(content::WebContents* web_contents,
+                             const base::string16& message_text,
+                             bool is_reload,
+                             const DialogClosedCallback& callback) override;
+  bool HandleJavaScriptDialog(content::WebContents* web_contents,
+                              bool accept,
+                              const base::string16* prompt_override) override;
+  void CancelActiveAndPendingDialogs(
+      content::WebContents* web_contents) override;
+  void WebContentsDestroyed(content::WebContents* web_contents) override;
+
+  base::string16 GetTitle(content::WebContents* web_contents,
+                          const GURL& origin_url,
+                          const std::string& accept_lang,
+                          bool is_alert);
+
+  // Wrapper around a DialogClosedCallback so that we can intercept it before
+  // passing it onto the original callback.
+  void OnDialogClosed(content::WebContents* web_contents,
+                      DialogClosedCallback callback,
+                      bool success,
+                      const base::string16& user_input);
+
+  // Mapping between the WebContents and their extra data. The key
+  // is a void* because the pointer is just a cookie and is never dereferenced.
+  JavaScriptAppModalDialog::ExtraDataMap javascript_dialog_extra_data_;
+
+  scoped_ptr<JavaScriptDialogExtensionsClient> extensions_client_;
+  scoped_ptr<JavaScriptNativeDialogFactory> native_dialog_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(JavaScriptDialogManager);
+};
 
 #endif  // COMPONENTS_APP_MODAL_DIALOGS_JAVASCRIPT_DIALOG_MANAGER_H_