Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 688773002: Adding instrumentation to locate the source of jankiness. (Closed)

Created:
6 years, 1 month ago by vadimt
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding instrumentation to locate the source of jankiness. Previous instrumentations showed that URLRequestResourceBundleJob::GetData alone is responsible for 20.5 janks per hour in IO thread. I need to instrument the code inside it to find out which part causes jank. This is a mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after. A number of similar CLs were landed, and none of them caused issues. They've helped to find and fix janky code. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers. The task gets created only in developer build and in Canary channel. BUG=422489 Committed: https://crrev.com/d45fc9174cc4fb03eebdcb71d289afc7d1de00b3 Cr-Commit-Position: refs/heads/master@{#302005}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/browser/extensions/chrome_url_request_util.cc View 1 chunk +16 lines, -0 lines 2 comments Download

Messages

Total messages: 9 (2 generated)
vadimt
kalman@, please provide OWNER's approval
6 years, 1 month ago (2014-10-29 23:30:59 UTC) #2
not at google - send to devlin
lgtm
6 years, 1 month ago (2014-10-29 23:31:42 UTC) #3
not at google - send to devlin
https://codereview.chromium.org/688773002/diff/1/chrome/browser/extensions/chrome_url_request_util.cc File chrome/browser/extensions/chrome_url_request_util.cc (right): https://codereview.chromium.org/688773002/diff/1/chrome/browser/extensions/chrome_url_request_util.cc#newcode102 chrome/browser/extensions/chrome_url_request_util.cc:102: base::Unretained(read_mime_type)), (hopefully it's not one of these Binds, in ...
6 years, 1 month ago (2014-10-29 23:34:16 UTC) #4
vadimt
https://codereview.chromium.org/688773002/diff/1/chrome/browser/extensions/chrome_url_request_util.cc File chrome/browser/extensions/chrome_url_request_util.cc (right): https://codereview.chromium.org/688773002/diff/1/chrome/browser/extensions/chrome_url_request_util.cc#newcode102 chrome/browser/extensions/chrome_url_request_util.cc:102: base::Unretained(read_mime_type)), On 2014/10/29 23:34:16, kalman wrote: > (hopefully it's ...
6 years, 1 month ago (2014-10-29 23:38:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688773002/1
6 years, 1 month ago (2014-10-29 23:39:57 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 01:13:14 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 01:14:20 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d45fc9174cc4fb03eebdcb71d289afc7d1de00b3
Cr-Commit-Position: refs/heads/master@{#302005}

Powered by Google App Engine
This is Rietveld 408576698