Remove duplicate name attribute writing for AX tree on Windows.

Remove duplicate name attribute writing.
The name attribute is repeated in AX tree formatter on Windows
because WriteAttrubute() is called twice for the name attribute.
This patch makes formatter write it only once.

BUG=N/A

Committed: https://crrev.com/c2853a5cb79d87478f6ea60566d3bb12ca4b4653
Cr-Commit-Position: refs/heads/master@{#302490}

[je_julie(Not used), 2014-10-29 13:58:40]

je_julie.kim@samsung.com changed reviewers:
+ aboxhall@chromium.org, dmazzoni@chromium.org

[je_julie(Not used), 2014-10-29 14:19:20]

aboxhall and Dominic,
When we check AX tree on Windows, we can see it like below.

ROLE_SYSTEM_STATICTEXT name='test' name='test' display:block location=(8, 9)
size=(28, 16) index_in_parent=0 n_relations=0 n_characters=4 caret_offset=0
n_selections=0

The 'name' attribute is always double only on Windows.
I was name attribute is written twice in AccessibilityTreeFormatter::ToString()
for Windows.
Because 'ALL_ATTRIBUTES' includes 'name', I think we don't need to
writeAttribute for name before loop.

PTAL.

[dmazzoni, 2014-10-29 15:15:18]

lgtm

Thanks!

Do any test expectations need to be updated or are they all fine?

[je_julie(Not used), 2014-10-31 16:19:48]

On 2014/10/29 15:15:18, dmazzoni wrote:
> lgtm
> 
> Thanks!
> 
> Do any test expectations need to be updated or are they all fine?

Hi Dominic,
I realized that we need name attribute as a default because
until now the expected test results were generated with it.
So, I think we'd better remove name attribute from 'ALL_ATTRIBUTES
' among two names.
What do you think?

[dmazzoni, 2014-10-31 16:30:21]

On 2014/10/31 16:19:48, je_julie wrote:
> On 2014/10/29 15:15:18, dmazzoni wrote:
> > lgtm
> > 
> > Thanks!
> > 
> > Do any test expectations need to be updated or are they all fine?
> 
> Hi Dominic,
> I realized that we need name attribute as a default because
> until now the expected test results were generated with it.
> So, I think we'd better remove name attribute from 'ALL_ATTRIBUTES
> ' among two names.
> What do you think?

What if you add "name" to AddDefaultFilters in
dump_accessibility_tree_browsertest.cc?

[shreeramk, 2014-11-01 08:03:05]

On 2014/10/31 16:30:21, dmazzoni wrote:
> On 2014/10/31 16:19:48, je_julie wrote:
> > On 2014/10/29 15:15:18, dmazzoni wrote:
> > > lgtm
> > > 
> > > Thanks!
> > > 
> > > Do any test expectations need to be updated or are they all fine?
> > 
> > Hi Dominic,
> > I realized that we need name attribute as a default because
> > until now the expected test results were generated with it.
> > So, I think we'd better remove name attribute from 'ALL_ATTRIBUTES
> > ' among two names.
> > What do you think?
> 
> What if you add "name" to AddDefaultFilters in
> dump_accessibility_tree_browsertest.cc?


If you check chrome://accessibility, name attribute is dumped twice. I observed
this long back, but always forgot to log this bug.

[shreeramk, 2014-11-01 08:06:50]

On 2014/11/01 08:03:05, shreeramk_OOO_2nd_Nov wrote:
> On 2014/10/31 16:30:21, dmazzoni wrote:
> > On 2014/10/31 16:19:48, je_julie wrote:
> > > On 2014/10/29 15:15:18, dmazzoni wrote:
> > > > lgtm
> > > > 
> > > > Thanks!
> > > > 
> > > > Do any test expectations need to be updated or are they all fine?
> > > 
> > > Hi Dominic,
> > > I realized that we need name attribute as a default because
> > > until now the expected test results were generated with it.
> > > So, I think we'd better remove name attribute from 'ALL_ATTRIBUTES
> > > ' among two names.
> > > What do you think?
> > 
> > What if you add "name" to AddDefaultFilters in
> > dump_accessibility_tree_browsertest.cc?
> 
> 
> If you check chrome://accessibility, name attribute is dumped twice. I
observed
> this long back, but always forgot to log this bug.

@je_julie: I think this issue is reproducible only when we check the ax tree for
a html page in chrome://accessibility. Right?

[je_julie(Not used), 2014-11-01 11:17:07]

On 2014/11/01 08:06:50, shreeramk_OOO_2nd_Nov wrote:
> On 2014/11/01 08:03:05, shreeramk_OOO_2nd_Nov wrote:
> > On 2014/10/31 16:30:21, dmazzoni wrote:
> > > On 2014/10/31 16:19:48, je_julie wrote:
> > > > On 2014/10/29 15:15:18, dmazzoni wrote:
> > > > > lgtm
> > > > > 
> > > > > Thanks!
> > > > > 
> > > > > Do any test expectations need to be updated or are they all fine?
> > > > 
> > > > Hi Dominic,
> > > > I realized that we need name attribute as a default because
> > > > until now the expected test results were generated with it.
> > > > So, I think we'd better remove name attribute from 'ALL_ATTRIBUTES
> > > > ' among two names.
> > > > What do you think?
> > > 
> > > What if you add "name" to AddDefaultFilters in
> > > dump_accessibility_tree_browsertest.cc?
> > 
> > 
> > If you check chrome://accessibility, name attribute is dumped twice. I
> observed
> > this long back, but always forgot to log this bug.
> 
> @je_julie: I think this issue is reproducible only when we check the ax tree
for
> a html page in chrome://accessibility. Right?

Hi Shreeram,
Yes, right. 
We can see the problem with AX tree on chrome://accessibility.

[je_julie(Not used), 2014-11-01 11:22:44]

> What if you add "name" to AddDefaultFilters in
> dump_accessibility_tree_browsertest.cc?

Dominic,
I added name attr to default filter.
Could you take a look?

[dmazzoni, 2014-11-03 20:30:41]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2014-11-03 20:30:41]

lgtm

[commit-bot: I haz the power, 2014-11-03 20:32:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/688653002/40001

[commit-bot: I haz the power, 2014-11-03 21:48:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-03 21:50:58]

Patchset 3 (id:??) landed as
https://crrev.com/c2853a5cb79d87478f6ea60566d3bb12ca4b4653
Cr-Commit-Position: refs/heads/master@{#302490}