Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: client/crashpad_info.cc

Issue 688643002: Fix a few documentation problems (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | compat/non_win/dbghelp.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 12 matching lines...) Expand all
23 #endif 23 #endif
24 24
25 namespace { 25 namespace {
26 26
27 static const uint32_t kCrashpadInfoVersion = 1; 27 static const uint32_t kCrashpadInfoVersion = 1;
28 28
29 } // namespace 29 } // namespace
30 30
31 namespace crashpad { 31 namespace crashpad {
32 32
33 #if CXX_LIBRARY_VERSION >= 2011 33 #if CXX_LIBRARY_VERSION >= 2011 || DOXYGEN
34 // In C++11, check that CrashpadInfo has standard layout, which is what is 34 // In C++11, check that CrashpadInfo has standard layout, which is what is
35 // actually important. 35 // actually important.
36 static_assert(std::is_standard_layout<CrashpadInfo>::value, 36 static_assert(std::is_standard_layout<CrashpadInfo>::value,
37 "CrashpadInfo must be standard layout"); 37 "CrashpadInfo must be standard layout");
38 #else 38 #else
39 // In C++98 (ISO 14882), section 9.5.1 says that a union cannot have a member 39 // In C++98 (ISO 14882), section 9.5.1 says that a union cannot have a member
40 // with a non-trivial ctor, copy ctor, dtor, or assignment operator. Use this 40 // with a non-trivial ctor, copy ctor, dtor, or assignment operator. Use this
41 // property to ensure that CrashpadInfo remains POD. This doesn’t work for C++11 41 // property to ensure that CrashpadInfo remains POD. This doesn’t work for C++11
42 // because the requirements for unions have been relaxed. 42 // because the requirements for unions have been relaxed.
43 union Compile_Assert { 43 union Compile_Assert {
(...skipping 25 matching lines...) Expand all
69 : signature_(kSignature), 69 : signature_(kSignature),
70 size_(sizeof(*this)), 70 size_(sizeof(*this)),
71 version_(kCrashpadInfoVersion), 71 version_(kCrashpadInfoVersion),
72 padding_0_(0), 72 padding_0_(0),
73 simple_annotations_(nullptr) { 73 simple_annotations_(nullptr) {
74 } 74 }
75 75
76 const uint32_t CrashpadInfo::kSignature; 76 const uint32_t CrashpadInfo::kSignature;
77 77
78 } // namespace crashpad 78 } // namespace crashpad
OLDNEW
« no previous file with comments | « no previous file | compat/non_win/dbghelp.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698