components/autofill/content/common/autofill_messages.h - Issue 688633004: Do not haul suggestions back to browser in AutofillHostMsg_ShowPasswordSuggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/common/autofill_messages.h

Issue 688633004: Do not haul suggestions back to browser in AutofillHostMsg_ShowPasswordSuggestions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments removed, iterator renamed Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/password_autofill_agent_browsertest.cc ('k') | components/autofill/content/renderer/password_autofill_agent.cc » ('j') | components/password_manager/core/browser/password_autofill_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/common/autofill_messages.h

diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h

index 25d8277981dcb2355e7f5b637bb87aaaf8a095df..e339a6445bf647809971e24f66b528f2e6d2a25b 100644

--- a/components/autofill/content/common/autofill_messages.h

+++ b/components/autofill/content/common/autofill_messages.h

@@ -285,13 +285,12 @@ IPC_MESSAGE_ROUTED2(AutofillHostMsg_AddPasswordFormMapping,

autofill::FormFieldData, /* the user name field */

autofill::PasswordFormFillData /* password pairings */)

-// Instruct the browser to show a popup with the following suggestions from the

-// password manager.

+// Instruct the browser to show a popup with suggestions for the form field.

IPC_MESSAGE_ROUTED4(AutofillHostMsg_ShowPasswordSuggestions,

autofill::FormFieldData /* the form field */,

- gfx::RectF /* input field bounds, window-relative */,

- std::vector<base::string16> /* suggestions */,

- std::vector<base::string16> /* realms */)

+ base::string16 /* username typed by user */,

+ bool /* show all suggestions */,

+ gfx::RectF /* input field bounds, window-relative */)

// Inform browser of data list values for the curent field.

IPC_MESSAGE_ROUTED2(AutofillHostMsg_SetDataList,