components/password_manager/core/browser/password_autofill_manager.h - Issue 688633004: Do not haul suggestions back to browser in AutofillHostMsg_ShowPasswordSuggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_autofill_manager.h

Issue 688633004: Do not haul suggestions back to browser in AutofillHostMsg_ShowPasswordSuggestions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_autofill_agent.cc ('K') | « components/autofill/content/renderer/password_autofill_agent.cc ('k') | components/password_manager/core/browser/password_autofill_manager.cc » ('j') | components/password_manager/core/browser/password_autofill_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_autofill_manager.h

diff --git a/components/password_manager/core/browser/password_autofill_manager.h b/components/password_manager/core/browser/password_autofill_manager.h

index 88420c9a279f905aad27da8bf8ca5676aa50699d..f3d4f5d7319c94eba7941b94e133f64375d587a4 100644

--- a/components/password_manager/core/browser/password_autofill_manager.h

+++ b/components/password_manager/core/browser/password_autofill_manager.h

@@ -44,11 +44,10 @@ class PasswordAutofillManager : public autofill::AutofillPopupDelegate {

// Handles a request from the renderer to show a popup with the given

// |suggestions| from the password manager.

- void OnShowPasswordSuggestions(

- const autofill::FormFieldData& field,

- const gfx::RectF& bounds,

- const std::vector<base::string16>& suggestions,

- const std::vector<base::string16>& realms);

+ void OnShowPasswordSuggestions(const autofill::FormFieldData& field,

+ const base::string16& typed_username,

+ bool show_all,

+ const gfx::RectF& bounds);

// Invoked to clear any page specific cached values.

void Reset();