Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 688633003: Update openjpeg to r2920 (Closed)

Created:
6 years, 1 month ago by Bo Xu
Modified:
5 years, 9 months ago
Reviewers:
Tom Sepez
CC:
Tom Sepez, jun_fang
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update to r2920 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/j2k.c View 1 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Bo Xu
Tom, please review this update. Thanks.
6 years, 1 month ago (2014-10-30 17:25:16 UTC) #1
Tom Sepez
LGTM. l_cp->ppm_len is unsigned, so the overflow check is valid.
6 years, 1 month ago (2014-10-30 17:46:34 UTC) #3
Bo Xu
On 2014/10/30 17:46:34, Tom Sepez wrote: > LGTM. l_cp->ppm_len is unsigned, so the overflow check ...
6 years, 1 month ago (2014-10-30 18:16:24 UTC) #4
Tom Sepez
Still LGTM.
6 years, 1 month ago (2014-10-30 19:37:14 UTC) #5
Bo Xu
6 years, 1 month ago (2014-10-30 20:11:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2b327f83ffcceca1911479c4afddafe51f0e37ba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698