Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 688633002: [turbofan] add configuration parameters for register allocator (Closed)

Created:
6 years, 1 month ago by dcarney
Modified:
6 years, 1 month ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] add configuration parameters for register allocator T=jarin@chromium.org BUG= R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25008

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : arches #

Patch Set 5 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -90 lines) Patch
M src/compiler/arm/linkage-arm.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/arm64/linkage-arm64.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/code-generator-impl.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/common-operator.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/graph-visualizer.cc View 1 2 2 chunks +7 lines, -9 lines 0 comments Download
M src/compiler/ia32/linkage-ia32.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction.h View 2 chunks +11 lines, -9 lines 0 comments Download
M src/compiler/instruction.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-graph.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/linkage.h View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M src/compiler/linkage.cc View 1 2 3 chunks +3 lines, -4 lines 0 comments Download
M src/compiler/linkage-impl.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/mips/linkage-mips.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/register-allocator.h View 1 6 chunks +25 lines, -15 lines 1 comment Download
M src/compiler/register-allocator.cc View 1 2 18 chunks +51 lines, -36 lines 1 comment Download
M src/compiler/x64/linkage-x64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/interface-descriptors.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/interface-descriptors.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dcarney
ptal
6 years, 1 month ago (2014-10-29 15:33:41 UTC) #2
Jarin
lgtm with nits. https://codereview.chromium.org/688633002/diff/80001/src/compiler/register-allocator.cc File src/compiler/register-allocator.cc (right): https://codereview.chromium.org/688633002/diff/80001/src/compiler/register-allocator.cc#newcode1889 src/compiler/register-allocator.cc:1889: // this in RegisterAllocator. Why would ...
6 years, 1 month ago (2014-10-29 17:37:43 UTC) #3
dcarney
6 years, 1 month ago (2014-10-30 09:01:23 UTC) #4
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as 25008 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698