Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: Source/core/inspector/ScriptCallFrame.cpp

Issue 688623002: [Thread-safe] Remove TracedValue::setArray (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/ScriptCallFrame.cpp
diff --git a/Source/core/inspector/ScriptCallFrame.cpp b/Source/core/inspector/ScriptCallFrame.cpp
index ef69b23f06fc500f17a3b4139c117a4f13af6835..1cdaede7af02deab1e6739ee2a0f4a72413c185e 100644
--- a/Source/core/inspector/ScriptCallFrame.cpp
+++ b/Source/core/inspector/ScriptCallFrame.cpp
@@ -31,6 +31,8 @@
#include "config.h"
#include "core/inspector/ScriptCallFrame.h"
+#include "platform/TracedValue.h"
+
namespace blink {
ScriptCallFrame::ScriptCallFrame()
@@ -55,6 +57,8 @@ ScriptCallFrame::~ScriptCallFrame()
{
}
+// buildInspectorObject() and addInspectorObject() should set the same fields.
+// If either of them is modified, the other should be also modified.
PassRefPtr<TypeBuilder::Console::CallFrame> ScriptCallFrame::buildInspectorObject() const
{
return TypeBuilder::Console::CallFrame::create()
@@ -66,4 +70,15 @@ PassRefPtr<TypeBuilder::Console::CallFrame> ScriptCallFrame::buildInspectorObjec
.release();
}
+void ScriptCallFrame::addInspectorObject(TracedValue* value) const
+{
+ value->beginDictionary();
+ value->setString("functionName", m_functionName);
+ value->setString("scriptId", m_scriptId);
+ value->setString("url", m_scriptName);
+ value->setInteger("lineNumber", m_lineNumber);
+ value->setInteger("columnNumber", m_column);
+ value->endDictionary();
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698