Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Unified Diff: Source/core/inspector/InspectorTraceEvents.cpp

Issue 688623002: [Thread-safe] Remove TracedValue::setArray (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/inspector/ScriptCallFrame.h » ('j') | Source/core/inspector/ScriptCallStack.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorTraceEvents.cpp
diff --git a/Source/core/inspector/InspectorTraceEvents.cpp b/Source/core/inspector/InspectorTraceEvents.cpp
index a1b7ba2a13f723d61b67c0a8721945779686a496..5c25b86e4838a7a237578fb68980fb2966df68d0 100644
--- a/Source/core/inspector/InspectorTraceEvents.cpp
+++ b/Source/core/inspector/InspectorTraceEvents.cpp
@@ -168,7 +168,7 @@ PassRefPtr<TracedValue> InspectorScheduleStyleInvalidationTrackingEvent::fillCom
value->setString("invalidationSet", descendantInvalidationSetToIdString(invalidationSet));
value->setString("invalidatedSelectorId", invalidatedSelector);
if (RefPtrWillBeRawPtr<ScriptCallStack> stackTrace = createScriptCallStack(maxInvalidationTrackingCallstackSize, true))
- value->setArray("stackTrace", stackTrace->buildInspectorArray()->asArray());
+ stackTrace->setInspectorArray(value.get(), "stackTrace");
return value.release();
}
@@ -259,7 +259,7 @@ PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorStyleRecalcInvalidatio
value->setString("reason", reason.reasonString());
value->setString("extraData", reason.extraData());
if (RefPtrWillBeRawPtr<ScriptCallStack> stackTrace = createScriptCallStack(maxInvalidationTrackingCallstackSize, true))
- value->setArray("stackTrace", stackTrace->buildInspectorArray()->asArray());
+ stackTrace->setInspectorArray(value.get(), "stackTrace");
return value.release();
}
@@ -326,7 +326,7 @@ PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorLayoutInvalidationTrac
value->setString("frame", toHexString(renderer->frame()));
setGeneratingNodeInfo(value.get(), renderer, "nodeId", "nodeName");
if (RefPtrWillBeRawPtr<ScriptCallStack> stackTrace = createScriptCallStack(maxInvalidationTrackingCallstackSize, true))
- value->setArray("stackTrace", stackTrace->buildInspectorArray()->asArray());
+ stackTrace->setInspectorArray(value.get(), "stackTrace");
return value.release();
}
« no previous file with comments | « no previous file | Source/core/inspector/ScriptCallFrame.h » ('j') | Source/core/inspector/ScriptCallStack.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698