[Thread-safe] Remove TracedValue::setArray

Source/core/inspector/ScriptCallStack.h

 /*
  * Copyright (c) 2008, 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 23 matching lines @@
 #include "core/InspectorTypeBuilder.h"
 #include "core/inspector/ScriptCallFrame.h"
 #include "platform/heap/Handle.h"
 #include "wtf/Forward.h"
 #include "wtf/RefCounted.h"
 #include "wtf/Vector.h"
 
 namespace blink {
 
 class ScriptAsyncCallStack;
+class TracedValue;
 
 class ScriptCallStack final : public RefCountedWillBeGarbageCollectedFinalized<ScriptCallStack> {
     DECLARE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(ScriptCallStack);
 public:
     static const size_t maxCallStackSizeToCapture = 200;
 
     static PassRefPtrWillBeRawPtr<ScriptCallStack> create(Vector<ScriptCallFrame>&);
 
     const ScriptCallFrame &at(size_t) const;
     size_t size() const;
 
     PassRefPtrWillBeRawPtr<ScriptAsyncCallStack> asyncCallStack() const;
     void setAsyncCallStack(PassRefPtrWillBeRawPtr<ScriptAsyncCallStack>);
 
     PassRefPtr<TypeBuilder::Array<TypeBuilder::Console::CallFrame> > buildInspectorArray() const;
+    void setInspectorArray(TracedValue*, const char* name) const;

[yurys, 2014/11/07 13:15:27]

nit: can you rename it into toTracedValue, otherwise the callsites look as if
you were setting a field on ScriptCallStack?

[hiroshige, 2014/11/10 08:02:59]

Done. Should I also rename ScriptCallFrame::addInspectorObject to e.g.
toTracedValue?

[yurys, 2014/11/10 08:08:17]

I think so, it would be more consistent.

[hiroshige, 2014/11/10 08:19:09]

Done.

 
     void trace(Visitor*);
 
 private:
     explicit ScriptCallStack(Vector<ScriptCallFrame>&);
 
     Vector<ScriptCallFrame> m_frames;
     RefPtrWillBeMember<ScriptAsyncCallStack> m_asyncCallStack;
 };
 
 } // namespace blink
 
 #endif // ScriptCallStack_h