Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: Source/core/inspector/ScriptCallStack.cpp

Issue 688623002: [Thread-safe] Remove TracedValue::setArray (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2008, Google Inc. All rights reserved. 2 * Copyright (c) 2008, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 14 matching lines...) Expand all
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "config.h" 31 #include "config.h"
32 #include "core/inspector/ScriptCallStack.h" 32 #include "core/inspector/ScriptCallStack.h"
33 33
34 #include "core/inspector/ScriptAsyncCallStack.h" 34 #include "core/inspector/ScriptAsyncCallStack.h"
35 #include "platform/TracedValue.h"
35 36
36 namespace blink { 37 namespace blink {
37 38
38 DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(ScriptCallStack); 39 DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(ScriptCallStack);
39 40
40 PassRefPtrWillBeRawPtr<ScriptCallStack> ScriptCallStack::create(Vector<ScriptCal lFrame>& frames) 41 PassRefPtrWillBeRawPtr<ScriptCallStack> ScriptCallStack::create(Vector<ScriptCal lFrame>& frames)
41 { 42 {
42 return adoptRefWillBeNoop(new ScriptCallStack(frames)); 43 return adoptRefWillBeNoop(new ScriptCallStack(frames));
43 } 44 }
44 45
(...skipping 24 matching lines...) Expand all
69 } 70 }
70 71
71 PassRefPtr<TypeBuilder::Array<TypeBuilder::Console::CallFrame> > ScriptCallStack ::buildInspectorArray() const 72 PassRefPtr<TypeBuilder::Array<TypeBuilder::Console::CallFrame> > ScriptCallStack ::buildInspectorArray() const
72 { 73 {
73 RefPtr<TypeBuilder::Array<TypeBuilder::Console::CallFrame> > frames = TypeBu ilder::Array<TypeBuilder::Console::CallFrame>::create(); 74 RefPtr<TypeBuilder::Array<TypeBuilder::Console::CallFrame> > frames = TypeBu ilder::Array<TypeBuilder::Console::CallFrame>::create();
74 for (size_t i = 0; i < m_frames.size(); i++) 75 for (size_t i = 0; i < m_frames.size(); i++)
75 frames->addItem(m_frames.at(i).buildInspectorObject()); 76 frames->addItem(m_frames.at(i).buildInspectorObject());
76 return frames; 77 return frames;
77 } 78 }
78 79
80 void ScriptCallStack::setInspectorArray(TracedValue* value, const char* name) co nst
81 {
82 value->beginArray(name);
83 for (size_t i = 0; i < m_frames.size(); i++)
84 m_frames.at(i).addInspectorObject(value);
85 value->endArray();
86 }
87
79 void ScriptCallStack::trace(Visitor* visitor) 88 void ScriptCallStack::trace(Visitor* visitor)
80 { 89 {
81 visitor->trace(m_asyncCallStack); 90 visitor->trace(m_asyncCallStack);
82 } 91 }
83 92
84 } // namespace blink 93 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698