Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 688593003: Change the name of the "Lock" string in the Avatar Menu that locks the user's profile. (Closed)

Created:
6 years, 1 month ago by Mike Lerman
Modified:
6 years, 1 month ago
Reviewers:
noms (inactive)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change the name of the "Lock" string in the Avatar Menu that locks the user's profile. BUG=427580 Committed: https://crrev.com/6c35c3b25bfed9c562f8dae7bcd212dff6c75ff8 Cr-Commit-Position: refs/heads/master@{#302447}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mike Lerman
Hi Monica, Lock string change to review, please. Thanks, Mike
6 years, 1 month ago (2014-11-03 16:52:21 UTC) #2
noms (inactive)
Ooof, that description is pretty vague. Could you maybe update it to something like "Change ...
6 years, 1 month ago (2014-11-03 16:57:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688593003/1
6 years, 1 month ago (2014-11-03 17:01:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-03 17:52:43 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 17:54:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c35c3b25bfed9c562f8dae7bcd212dff6c75ff8
Cr-Commit-Position: refs/heads/master@{#302447}

Powered by Google App Engine
This is Rietveld 408576698