Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 688543003: Add timing of bitcode parser to Subzero. (Closed)

Created:
6 years, 1 month ago by Karl
Modified:
6 years, 1 month ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Add timing of bitcode parser to Subzero. Adds timers to each bitcode block parser in Subzero, to get a reading on how much time is used by the bitcode parser. BUG=None R=jvoung@chromium.org, stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=58455876adbd0fc92815bb0e2419363d569df2a5

Patch Set 1 #

Patch Set 2 : Fix formatting. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -39 lines) Patch
M src/IceTimerTree.def View 1 1 chunk +36 lines, -29 lines 0 comments Download
M src/PNaClTranslator.cpp View 1 8 chunks +27 lines, -8 lines 0 comments Download
M src/llvm2ice.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Karl
6 years, 1 month ago (2014-11-03 18:34:03 UTC) #2
jvoung (off chromium)
lgtm
6 years, 1 month ago (2014-11-03 19:18:43 UTC) #3
Jim Stichnoth
LGTM. It would be nice if the timer could be lifted into the base class ...
6 years, 1 month ago (2014-11-03 19:26:31 UTC) #4
Karl
6 years, 1 month ago (2014-11-03 19:29:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
58455876adbd0fc92815bb0e2419363d569df2a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698