Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 688543002: [Autofill] Don't save autocomplete text entered into fields with autocomplete="off" (Closed)

Created:
6 years, 1 month ago by Ilya Sherman
Modified:
6 years, 1 month ago
Reviewers:
Evan Stade
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Don't save autocomplete text entered into fields with autocomplete="off" This fixes a regression introduced in [ https://codereview.chromium.org/407083002 ]. BUG=423326 TEST=components_unittests R=estade@chromium.org Committed: https://crrev.com/dddf9472afb434be7695edbabffd734d3ac60997 Cr-Commit-Position: refs/heads/master@{#301985}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M components/autofill/core/browser/autocomplete_history_manager.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autocomplete_history_manager_unittest.cc View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Ilya Sherman
6 years, 1 month ago (2014-10-29 00:08:44 UTC) #1
Evan Stade
lgtm
6 years, 1 month ago (2014-10-29 22:34:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688543002/1
6 years, 1 month ago (2014-10-29 22:38:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 00:07:42 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 00:08:33 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dddf9472afb434be7695edbabffd734d3ac60997
Cr-Commit-Position: refs/heads/master@{#301985}

Powered by Google App Engine
This is Rietveld 408576698