src/typing.h - Issue 688533002: Add a few missing overrides found by a new clang warning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/typing.h

Issue 688533002: Add a few missing overrides found by a new clang warning. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/typing.h

===================================================================

--- src/typing.h (revision 24959)

+++ src/typing.h (working copy)

@@ -75,7 +75,7 @@

void VisitDeclarations(ZoneList<Declaration*>* declarations);

Jakob Kummerow 2014/10/29 10:17:45 ...and one more VisitDeclarations

Nico 2014/10/29 15:43:39 Yes: https://code.google.com/p/v8/issues/attachmen

void VisitStatements(ZoneList<Statement*>* statements);

Nico 2014/10/29 15:43:39 This one too: https://code.google.com/p/v8/issues/

-#define DECLARE_VISIT(type) virtual void Visit##type(type* node);

+#define DECLARE_VISIT(type) virtual void Visit##type(type* node) OVERRIDE;

AST_NODE_LIST(DECLARE_VISIT)

#undef DECLARE_VISIT

« src/full-codegen.h ('K') | « src/serialize.cc ('k') | no next file » | no next file with comments »