Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: src/typing.h

Issue 688533002: Add a few missing overrides found by a new clang warning. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/full-codegen.h ('K') | « src/serialize.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/typing.h
===================================================================
--- src/typing.h (revision 24959)
+++ src/typing.h (working copy)
@@ -75,7 +75,7 @@
void VisitDeclarations(ZoneList<Declaration*>* declarations);
Jakob Kummerow 2014/10/29 10:17:45 ...and one more VisitDeclarations
Nico 2014/10/29 15:43:39 Yes: https://code.google.com/p/v8/issues/attachmen
void VisitStatements(ZoneList<Statement*>* statements);
Nico 2014/10/29 15:43:39 This one too: https://code.google.com/p/v8/issues/
-#define DECLARE_VISIT(type) virtual void Visit##type(type* node);
+#define DECLARE_VISIT(type) virtual void Visit##type(type* node) OVERRIDE;
AST_NODE_LIST(DECLARE_VISIT)
#undef DECLARE_VISIT
« src/full-codegen.h ('K') | « src/serialize.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698