Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Side by Side Diff: src/ic/ic.h

Issue 688533002: Add a few missing overrides found by a new clang warning. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_IC_H_ 5 #ifndef V8_IC_H_
6 #define V8_IC_H_ 6 #define V8_IC_H_
7 7
8 #include "src/ic/ic-state.h" 8 #include "src/ic/ic-state.h"
9 #include "src/macro-assembler.h" 9 #include "src/macro-assembler.h"
10 10
(...skipping 398 matching lines...) Expand 10 before | Expand all | Expand 10 after
409 } 409 }
410 410
411 virtual Handle<Code> megamorphic_stub() OVERRIDE; 411 virtual Handle<Code> megamorphic_stub() OVERRIDE;
412 412
413 // Update the inline cache and the global stub cache based on the 413 // Update the inline cache and the global stub cache based on the
414 // lookup result. 414 // lookup result.
415 void UpdateCaches(LookupIterator* lookup); 415 void UpdateCaches(LookupIterator* lookup);
416 416
417 virtual Handle<Code> CompileHandler(LookupIterator* lookup, 417 virtual Handle<Code> CompileHandler(LookupIterator* lookup,
418 Handle<Object> unused, 418 Handle<Object> unused,
419 CacheHolderFlag cache_holder); 419 CacheHolderFlag cache_holder) OVERRIDE;
420 420
421 private: 421 private:
422 virtual Handle<Code> pre_monomorphic_stub() const; 422 virtual Handle<Code> pre_monomorphic_stub() const;
423 static Handle<Code> pre_monomorphic_stub(Isolate* isolate, 423 static Handle<Code> pre_monomorphic_stub(Isolate* isolate,
424 ExtraICState extra_state); 424 ExtraICState extra_state);
425 425
426 Handle<Code> SimpleFieldLoad(FieldIndex index); 426 Handle<Code> SimpleFieldLoad(FieldIndex index);
427 427
428 static void Clear(Isolate* isolate, Address address, Code* target, 428 static void Clear(Isolate* isolate, Address address, Code* target,
429 ConstantPoolArray* constant_pool); 429 ConstantPoolArray* constant_pool);
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
538 538
539 static Handle<Code> pre_monomorphic_stub(Isolate* isolate, 539 static Handle<Code> pre_monomorphic_stub(Isolate* isolate,
540 StrictMode strict_mode); 540 StrictMode strict_mode);
541 541
542 // Update the inline cache and the global stub cache based on the 542 // Update the inline cache and the global stub cache based on the
543 // lookup result. 543 // lookup result.
544 void UpdateCaches(LookupIterator* lookup, Handle<Object> value, 544 void UpdateCaches(LookupIterator* lookup, Handle<Object> value,
545 JSReceiver::StoreFromKeyed store_mode); 545 JSReceiver::StoreFromKeyed store_mode);
546 virtual Handle<Code> CompileHandler(LookupIterator* lookup, 546 virtual Handle<Code> CompileHandler(LookupIterator* lookup,
547 Handle<Object> value, 547 Handle<Object> value,
548 CacheHolderFlag cache_holder); 548 CacheHolderFlag cache_holder) OVERRIDE;
549 549
550 private: 550 private:
551 inline void set_target(Code* code); 551 inline void set_target(Code* code);
552 552
553 static void Clear(Isolate* isolate, Address address, Code* target, 553 static void Clear(Isolate* isolate, Address address, Code* target,
554 ConstantPoolArray* constant_pool); 554 ConstantPoolArray* constant_pool);
555 555
556 friend class IC; 556 friend class IC;
557 }; 557 };
558 558
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
732 732
733 // Support functions for interceptor handlers. 733 // Support functions for interceptor handlers.
734 DECLARE_RUNTIME_FUNCTION(LoadPropertyWithInterceptorOnly); 734 DECLARE_RUNTIME_FUNCTION(LoadPropertyWithInterceptorOnly);
735 DECLARE_RUNTIME_FUNCTION(LoadPropertyWithInterceptor); 735 DECLARE_RUNTIME_FUNCTION(LoadPropertyWithInterceptor);
736 DECLARE_RUNTIME_FUNCTION(LoadElementWithInterceptor); 736 DECLARE_RUNTIME_FUNCTION(LoadElementWithInterceptor);
737 DECLARE_RUNTIME_FUNCTION(StorePropertyWithInterceptor); 737 DECLARE_RUNTIME_FUNCTION(StorePropertyWithInterceptor);
738 } 738 }
739 } // namespace v8::internal 739 } // namespace v8::internal
740 740
741 #endif // V8_IC_H_ 741 #endif // V8_IC_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698