Issue 68853015: Convert the re2 GYP targets to be generated by GN.

Issue 68853015: Convert the re2 GYP targets to be generated by GN. (Closed)

Created:
7 years, 1 month ago by brettw

Modified:
6 years, 11 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Dirk Pranke

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Convert the re2 GYP targets to be generated by GN. BUG=288991 R=bradnelson@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245254

Patch Set 20 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -181 lines)			Patch
M	build/all.gyp	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser_chromeos.gypi	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_common.gypi	View	1 2 3 4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_renderer.gypi	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/tools/profile_reset/jtl_compiler.gyp	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	components/plugins.gypi	View	1 2 3 4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
M	components/url_matcher.gypi	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	content/content_browser.gypi	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/extensions.gyp	View	1 2 3 4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer_service.gypi	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/gpu_config.gypi	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/leveldatabase/leveldatabase.gyp	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/libaddressinput/libaddressinput.gyp	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15	1 chunk	+1 line, -1 line	0 comments	Download
A +	third_party/re2/BUILD.gn	View	1 2 3 4	2 chunks	+2 lines, -4 lines	0 comments	Download
D	third_party/re2/re2.gyp	View	1 2	1 chunk	+0 lines, -84 lines	0 comments	Download
M	tools/gn/secondary/third_party/re2/BUILD.gn	View	1 2 3 4	1 chunk	+0 lines, -77 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

bradn

lgtm https://codereview.chromium.org/68853015/diff/420001/third_party/re2/BUILD.gn File third_party/re2/BUILD.gn (left): https://codereview.chromium.org/68853015/diff/420001/third_party/re2/BUILD.gn#oldcode10 third_party/re2/BUILD.gn:10: external = true Why was this able to ...

7 years ago (2013-12-10 18:55:07 UTC) #3

brettw

https://codereview.chromium.org/68853015/diff/420001/third_party/re2/BUILD.gn File third_party/re2/BUILD.gn (left): https://codereview.chromium.org/68853015/diff/420001/third_party/re2/BUILD.gn#oldcode10 third_party/re2/BUILD.gn:10: external = true This change is what makes GN ...

7 years ago (2013-12-10 19:14:09 UTC) #4

bradn

7 years ago (2013-12-10 19:19:08 UTC) #5

brettw

6 years, 11 months ago (2014-01-16 18:44:05 UTC) #7

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/141063002/ by brettw@chromium.org.

The reason for reverting is: Broke Blink compile.

Expand Messages | Collapse Messages